[Bug][API] list paging missing totalpage #15619
Conversation
Signed-off-by: Gallardot <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15619 +/- ##
=========================================
Coverage 38.53% 38.53%
- Complexity 4783 4784 +1
=========================================
Files 1316 1316
Lines 45036 45043 +7
Branches 4821 4823 +2
=========================================
+ Hits 17354 17357 +3
- Misses 25792 25793 +1
- Partials 1890 1893 +3 ☔ View full report in Codecov by Sentry. |
|
|
#15148 is closed. Which deleted some code by mistake? @Gallardot |
|
Did you mean #15181? |
|
cc @ruanwenjun |
DaZuiZui
left a comment
DaZuiZui
left a comment
There was a problem hiding this comment.
This seems to achieve the same function, and is simpler
this.totalPage = Math.ceil(this.total / this.pageSize);
| return new PageInfo<>(currentPage, pageSize); | ||
| } | ||
|
|
||
| public Integer getTotalPage() { |
There was a problem hiding this comment.
This seems to achieve the same function, and is simpler
this.totalPage = Math.ceil(this.total / this.pageSize);
|
Thanks for fixing this Bug? |
Signed-off-by: Gallardot <[email protected]>
[Bug][API] list paging missing totalpage (apache#15619) See merge request logan/devops/apache/dolphinscheduler!21
|
our production environment meet this problem, When 3.2.2 release？ |
6 participants
Purpose of the pull request
#15181 deleted some code by mistake
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md