[Feature-14863][API] Support to manage what worker groups can be used for a project. #15600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinjiang
requested review from
SbloodyS,
caishunfeng and
zhongjiajie
as code owners
calvinjiang
changed the title
calvinjiang
added
feature
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| projectWorkerGroup.setUpdateTime(now); | ||
| int create = projectWorkerGroupMapper.insert(projectWorkerGroup); | ||
| if (create > 0) { | ||
| log.info("Success to add worker group [{}] for the project [{}] .", workerGroupName, |
Check failure
Code scanning / CodeQL
Log Injection
| log.info("Success to add worker group [{}] for the project [{}] .", workerGroupName, | ||
| project.getName()); | ||
| } else { | ||
| log.error("Failed to add worker group [{}] for the project [{}].", workerGroupName, |
Check failure
Code scanning / CodeQL
Log Injection
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15600 +/- ##
============================================
+ Coverage 38.55% 38.58% +0.02%
- Complexity 4777 4784 +7
============================================
Files 1310 1312 +2
Lines 44880 44978 +98
Branches 4808 4819 +11
============================================
+ Hits 17305 17354 +49
- Misses 25692 25734 +42
- Partials 1883 1890 +7 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This PR will close #14863.
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
The testing results are as follows: