[HotFix] Fix create parent directory will cause FileAlreadyExistsException #15576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
force-pushed
the
dev_wenjun_fixFileAlreadyExist
branch
from
551a243 to
c2a33cd
Compare
ruanwenjun
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15576 +/- ##
============================================
- Coverage 38.53% 38.53% -0.01%
Complexity 4766 4766
============================================
Files 1305 1305
Lines 44838 44841 +3
Branches 4806 4806
============================================
+ Hits 17278 17279 +1
- Misses 25684 25686 +2
Partials 1876 1876 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Files.createDirectory(path); | ||
| Files.setPosixFilePermissions(path, PERMISSION_755); | ||
| try { | ||
| Files.createDirectory(path); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| Files.setPosixFilePermissions(path, PERMISSION_755); | ||
| } catch (FileAlreadyExistsException fileAlreadyExistsException) { | ||
| // Catch the FileAlreadyExistsException here to avoid create the same parent directory in parallel | ||
| log.debug("The directory: {} already exists", path); |
Check failure
Code scanning / CodeQL
Log Injection
|
zhongjiajie
pushed a commit
that referenced
this pull request
Feb 6, 2024
…5576) Co-authored-by: Rick Cheng <[email protected]> (cherry picked from commit 4541e74)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md