Skip to content

Set the workflow instance ready state to running in failover #15572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fuchanghai merged 1 commit into from
Feb 6, 2024
Merged

Set the workflow instance ready state to running in failover #15572

fuchanghai merged 1 commit into from
Feb 6, 2024

Conversation

@ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Feb 5, 2024 •
edited
Loading

Purpose of the pull request

close #15573

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added the bug Something isn't working label Feb 5, 2024
@ruanwenjun ruanwenjun self-assigned this Feb 5, 2024
fuchanghai
fuchanghai reviewed Feb 6, 2024
View reviewed changes
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ruanwenjun If do this, the historical state added in the method processServiceImpl#constructProcessInstance will be different from the actual one. Can I modify the command_type of Recover_Tolerance_fault_process in the method `` processServiceImpl#constructProcessInstance``` to solve this problem?

@ruanwenjun
Copy link
Member Author

ruanwenjun commented Feb 6, 2024

hi @ruanwenjun If do this, the historical state added in the method processServiceImpl#constructProcessInstance will be different from the actual one. Can I modify the command_type of Recover_Tolerance_fault_process in the method `` processServiceImpl#constructProcessInstance``` to solve this problem?

LGTM

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_setReadyStateToRunningWhenFailover branch from 86df159 to 28d30a6 Compare February 6, 2024 02:10
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (73a5a77) 38.52% compared to head (8ba5c69) 38.53%.

❗ Current head 8ba5c69 differs from pull request most recent head b812b8c. Consider uploading reports for the commit b812b8c to get more accurate results

Files Patch % Lines
...nscheduler/service/process/ProcessServiceImpl.java 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                dev   #15572   +/-   ##
=========================================
  Coverage     38.52%   38.53%           
- Complexity     4765     4766    +1     
=========================================
  Files          1305     1305           
  Lines         44841    44844    +3     
  Branches       4806     4808    +2     
=========================================
+ Hits          17275    17279    +4     
+ Misses        25689    25687    -2     
- Partials       1877     1878    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_setReadyStateToRunningWhenFailover branch from fa8641f to d4a68cc Compare February 6, 2024 04:01
rickchengx
rickchengx approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_setReadyStateToRunningWhenFailover branch from d4a68cc to b812b8c Compare February 6, 2024 05:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
57.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

fuchanghai
fuchanghai approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuchanghai fuchanghai merged commit 1b32e28 into apache:dev Feb 6, 2024
zhongjiajie pushed a commit that referenced this pull request Feb 6, 2024
@ruanwenjun @zhongjiajie
Set the workflow instance ready state to running in failover (#15572)
9bb5268 
(cherry picked from commit 1b32e28)
@ruanwenjun ruanwenjun deleted the dev_wenjun_setReadyStateToRunningWhenFailover branch November 23, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuchanghai fuchanghai fuchanghai approved these changes

@rickchengx rickchengx rickchengx approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

Assignees

@ruanwenjun ruanwenjun

Labels

3.2.1 backend bug Something isn't working ready-to-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] [Master] Master failover will not handle ready_stop and ready_pause workflow instance correctly.

4 participants

@ruanwenjun @codecov-commenter @fuchanghai @rickchengx