Skip to content

Conversation

@JohnZp
Copy link
Contributor

@JohnZp JohnZp commented Feb 5, 2024

…on in the worker

Purpose of the pull request

Fix the issue of missing disk usage reporting information in the worker.

Brief change log

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, Please link pr to your issue @JohnZp

@rickchengx rickchengx added improvement make more easy to user or prompt friendly 3.2.1 labels Feb 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b32e28) 38.53% compared to head (66a4309) 38.53%.

❗ Current head 66a4309 differs from pull request most recent head 38d1950. Consider uploading reports for the commit 38d1950 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15565      +/-   ##
============================================
- Coverage     38.53%   38.53%   -0.01%     
+ Complexity     4766     4765       -1     
============================================
  Files          1305     1305              
  Lines         44844    44845       +1     
  Branches       4808     4808              
============================================
  Hits          17279    17279              
  Misses        25687    25687              
- Partials       1878     1879       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2024

@rickchengx rickchengx merged commit 89da67d into apache:dev Feb 6, 2024
zhongjiajie pushed a commit that referenced this pull request Feb 6, 2024
…on in the worker (#15565)

Co-authored-by: Rick Cheng <[email protected]>
(cherry picked from commit 89da67d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.2.1 backend improvement make more easy to user or prompt friendly ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants