Fix exception occur in RpcServer side, it will not be sent to RpcClient #15536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15536 +/- ##
============================================
+ Coverage 38.10% 38.15% +0.04%
- Complexity 4698 4705 +7
============================================
Files 1304 1304
Lines 44818 44820 +2
Branches 4804 4805 +1
============================================
+ Hits 17080 17099 +19
+ Misses 25884 25870 -14
+ Partials 1854 1851 -3 ☔ View full report in Codecov by Sentry. |
|
ruanwenjun
deleted the
dev_wenjun_fixRPCWillNotSendServerExceptionToClient
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
When we meet an exception in server side, it's better to directly throw this exception in method call in client side.
Brief change log
Verify this pull request
Verify by UT.