[Doc][Docker] fix typo on start with docker #15534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbloodyS
reviewed
Jan 30, 2024
docs/docs/en/guide/start/docker.md
Outdated
Comment on lines
72
to
75
| # Initialize the database, make sure database <DATABASE> already exists | ||
| $ docker run -d --name dolphinscheduler-tools \ | ||
| -e DATABASE="postgresql" \ | ||
| -e SPRING_DATASOURCE_URL="jdbc:postgresql://localhost:5432/<DATABASE>" \ | ||
| -e SPRING_DATASOURCE_URL="jdbc:postgresql://localhost:5432/dolphinscheduler" \ |
Member
There was a problem hiding this comment.
I don't think this is a typo since we already have comment above.
Contributor
Author
There was a problem hiding this comment.
So I think maybe we should correct below 4 into DATABASE?
I think we should all changed to dolphinscheduler or .
or else it is confusing.
It is also a little bit confuse with SPRING_DATABASE configuration.
Member
There was a problem hiding this comment.
change others components env SPRING_DATASOURCE_URL LGTM
Contributor
Author
There was a problem hiding this comment.
change others components env
SPRING_DATASOURCE_URLLGTM
Thanks for discussion.
Updated.
ruanwenjun
added
the
minor
SbloodyS
approved these changes
Jan 31, 2024
zhongjiajie
pushed a commit
that referenced
this pull request
Feb 6, 2024
Co-authored-by: xiangzihao <[email protected]> Co-authored-by: Eric Gao <[email protected]> (cherry picked from commit 1b42d45)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix #15533
Brief change log
fix type on docker start guide.
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md