[Improvement] Directly Throw exception when taskInstancy log path is empty which log need to be queried #15511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15511 +/- ##
============================================
- Coverage 38.02% 38.02% -0.01%
Complexity 4692 4692
============================================
Files 1304 1304
Lines 44812 44778 -34
Branches 4803 4781 -22
============================================
- Hits 17038 17025 -13
+ Misses 25923 25902 -21
Partials 1851 1851 ☔ View full report in Codecov by Sentry. |
ruanwenjun
force-pushed
the
dev_wenjun_throwExceptionWhenTaskPathIsNull
branch
2 times, most recently
from
224c5e8 to
a88d150
Compare
fuchanghai
reviewed
Jan 19, 2024
| UNAUTHORIZED_USER_ERROR(10101, "unauthorized user error", "查询未授权用户错误"), | ||
| AUTHORIZED_USER_ERROR(10102, "authorized user error", "查询授权用户错误"), | ||
| QUERY_TASK_INSTANCE_LOG_ERROR(10103, "view task instance log error", "查询任务实例日志错误"), | ||
| QUERY_TASK_INSTANCE_LOG_ERROR(10103, "view task instance log error: {0}", "查询任务实例日志错误"), |
Member
There was a problem hiding this comment.
hi @ruanwenjun Should we make a slight modification and replace it with 查询任务实例日志错误: {0}
ruanwenjun
force-pushed
the
dev_wenjun_throwExceptionWhenTaskPathIsNull
branch
from
a88d150 to
4a12dea
Compare
ruanwenjun
force-pushed
the
dev_wenjun_throwExceptionWhenTaskPathIsNull
branch
from
4a12dea to
b33fd86
Compare
…g need to be queried
ruanwenjun
force-pushed
the
dev_wenjun_throwExceptionWhenTaskPathIsNull
branch
from
b33fd86 to
5fa31e0
Compare
ruanwenjun
force-pushed
the
dev_wenjun_throwExceptionWhenTaskPathIsNull
branch
from
5fa31e0 to
35001b5
Compare
|
ruanwenjun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Avoid send RPC to worker, cause worker NPE
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md