Skip to content

Conversation

@jackyyyyyssss
Copy link
Contributor

@jackyyyyyssss jackyyyyyssss commented Jan 11, 2024

Purpose of the pull request

fix #15476
image
java -help It's a classpath, not a class-path

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f7081b) 38.11% compared to head (64aac7d) 38.11%.

❗ Current head 64aac7d differs from pull request most recent head ac3e9c0. Consider uploading reports for the commit ac3e9c0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15470      +/-   ##
============================================
- Coverage     38.11%   38.11%   -0.01%     
  Complexity     4697     4697              
============================================
  Files          1299     1299              
  Lines         44775    44775              
  Branches       4797     4797              
============================================
- Hits          17067    17066       -1     
- Misses        25861    25862       +1     
  Partials       1847     1847              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SbloodyS SbloodyS added the 3.2.1 label Jan 12, 2024
@SbloodyS SbloodyS added this to the 3.2.1 milestone Jan 12, 2024
@SbloodyS SbloodyS merged commit bd48c99 into apache:dev Jan 12, 2024
liunaijie pushed a commit to liunaijie/dolphinscheduler that referenced this pull request Dec 2, 2024
* fix javatask bug

* cover

---------

Co-authored-by: 80597928 <[email protected]>
Co-authored-by: fuchanghai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Task] java task args erro

5 participants