Skip to content

[Improvement][UT] Improve Worker runner coverage #15428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rickchengx merged 4 commits into from
Mar 5, 2024
Merged

[Improvement][UT] Improve Worker runner coverage #15428

rickchengx merged 4 commits into from
Mar 5, 2024

Conversation

@pegasas
Copy link
Contributor

@pegasas pegasas commented Jan 4, 2024

Purpose of the pull request

resolve: #15396

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@pegasas pegasas changed the title [Improvement][UT] Improve Worker runner coverage [WIP][Improvement][UT] Improve Worker runner coverage Jan 4, 2024
@pegasas pegasas force-pushed the worker-runner-ut branch 3 times, most recently from 9bc577b to 1def983 Compare January 4, 2024 18:35
@pegasas pegasas changed the title [WIP][Improvement][UT] Improve Worker runner coverage [Improvement][UT] Improve Worker runner coverage Jan 7, 2024
@pegasas pegasas marked this pull request as ready for review January 7, 2024 01:03
@rickchengx
Copy link
Contributor

rickchengx commented Feb 5, 2024

Hi, @pegasas , please fix CI

@pegasas
Copy link
Contributor Author

pegasas commented Feb 5, 2024

Hi, @pegasas , please fix CI

It seems there's a lot refactor after last merge.
I will fix & re-commit.

@pegasas
Copy link
Contributor Author

pegasas commented Feb 5, 2024

Hi, @pegasas , please fix CI

It seems there's a lot refactor after last merge. I will fix & re-commit.

fixed.

@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly 3.3.0 labels Feb 5, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Feb 5, 2024
@rickchengx
Copy link
Contributor

rickchengx commented Feb 19, 2024

@pegasas please check the failed CI

@pegasas
Copy link
Contributor Author

pegasas commented Feb 19, 2024

@pegasas please check the failed CI

image
Done.
run spotless successfully in my local

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5213290) 38.58% compared to head (cd7da69) 38.94%.

❗ Current head cd7da69 differs from pull request most recent head 9c43999. Consider uploading reports for the commit 9c43999 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #15428      +/-   ##
============================================
+ Coverage     38.58%   38.94%   +0.36%     
- Complexity     4784     4832      +48     
============================================
  Files          1312     1312              
  Lines         44978    45009      +31     
  Branches       4819     4819              
============================================
+ Hits          17355    17531     +176     
+ Misses        25733    25574     -159     
- Partials       1890     1904      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rickchengx
rickchengx approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickchengx
Copy link
Contributor

rickchengx commented Feb 21, 2024

will merge tomorrow if no more comments

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rickchengx rickchengx merged commit e3bd263 into apache:dev Mar 5, 2024
@pegasas pegasas deleted the worker-runner-ut branch March 5, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickchengx rickchengx rickchengx approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

Assignees

@pegasas pegasas

Labels

3.3.0 backend improvement make more easy to user or prompt friendly ready-to-merge

Projects

None yet

Milestone

3.3.0-alpha

Development

Successfully merging this pull request may close these issues.

[Improvement][Unit Tests] Improve DolphinScheduler Worker unit tests

5 participants

@pegasas @rickchengx @codecov-commenter @SbloodyS @caishunfeng