[Improvement] Use Druid to split multiple sql #15367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
SbloodyS,
caishunfeng and
zhuangchong
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_useDruidParseSqlDev
branch
3 times, most recently
from
4720539 to
034c483
Compare
ruanwenjun
force-pushed
the
dev_wenjun_useDruidParseSqlDev
branch
4 times, most recently
from
6921e9a to
550d1c6
Compare
caishunfeng
previously approved these changes
Dec 27, 2023
| } | ||
|
|
||
| @Override | ||
| public List<String> splitAndRemoveComment(String sql) { |
Contributor
There was a problem hiding this comment.
Can you add some new UT for it?
Member
Author
There was a problem hiding this comment.
Done. Add some UT case for Oracle, Dorid, Mysql.
caishunfeng
changed the title
Contributor
|
Please add some pr description. |
ruanwenjun
force-pushed
the
dev_wenjun_useDruidParseSqlDev
branch
from
550d1c6 to
f2ddfa0
Compare
Member
Author
Done |
ruanwenjun
force-pushed
the
dev_wenjun_useDruidParseSqlDev
branch
from
f2ddfa0 to
79b6bce
Compare
ruanwenjun
force-pushed
the
dev_wenjun_useDruidParseSqlDev
branch
2 times, most recently
from
56ec086 to
9c3425a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15367 +/- ##
============================================
- Coverage 38.11% 38.11% -0.01%
+ Complexity 4698 4697 -1
============================================
Files 1300 1299 -1
Lines 44778 44783 +5
Branches 4800 4798 -2
============================================
- Hits 17069 17068 -1
- Misses 25858 25864 +6
Partials 1851 1851 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...va/org/apache/dolphinscheduler/plugin/datasource/oracle/param/OracleDataSourceProcessor.java
Fixed
Show fixed
Hide fixed
...java/org/apache/dolphinscheduler/plugin/datasource/trino/param/TrinoDataSourceProcessor.java
Fixed
Show fixed
Hide fixed
ruanwenjun
force-pushed
the
dev_wenjun_useDruidParseSqlDev
branch
4 times, most recently
from
5066043 to
8532464
Compare
ruanwenjun
force-pushed
the
dev_wenjun_useDruidParseSqlDev
branch
from
8532464 to
62b6b5b
Compare
ruanwenjun
force-pushed
the
dev_wenjun_useDruidParseSqlDev
branch
2 times, most recently
from
d916888 to
d8e1045
Compare
ruanwenjun
force-pushed
the
dev_wenjun_useDruidParseSqlDev
branch
from
d8e1045 to
e27bb5c
Compare
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Right now, we use
;\nto split the sql and use simple way to remove the comments. This cannot work will if the sql is complex, this PR will use Druid to split sql and remove comments.Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md