Fix check value rather than key in AbstractDataSourceProcessor#checkOther #15351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
changed the title
3 tasks
ruanwenjun
force-pushed
the
dev_wenjun_removeCheckParams
branch
from
f4a6616 to
d0994c4
Compare
ruanwenjun
force-pushed
the
dev_wenjun_removeCheckParams
branch
2 times, most recently
from
628442b to
6b8aa24
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15351 +/- ##
============================================
- Coverage 37.81% 37.80% -0.01%
Complexity 4680 4680
============================================
Files 1304 1304
Lines 44932 44933 +1
Branches 4810 4811 +1
============================================
Hits 16989 16989
Misses 26094 26094
- Partials 1849 1850 +1 ☔ View full report in Codecov by Sentry. |
ruanwenjun
force-pushed
the
dev_wenjun_removeCheckParams
branch
from
6b8aa24 to
e499694
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #15347.
We need to check key rather than value.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md