Skip to content

Conversation

@ruanwenjun
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_moveDelayToMaster branch 2 times, most recently from 9922289 to 398a7cb Compare December 6, 2023 04:05
@ruanwenjun ruanwenjun added the bug Something isn't working label Dec 6, 2023
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_moveDelayToMaster branch from 398a7cb to 2e23ea5 Compare December 6, 2023 04:12
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2119e41) 38.17% compared to head (e44787d) 38.19%.

❗ Current head e44787d differs from pull request most recent head 2e23ea5. Consider uploading reports for the commit 2e23ea5 to get more accurate results

Files Patch % Lines
.../server/master/runner/WorkflowExecuteRunnable.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15287      +/-   ##
============================================
+ Coverage     38.17%   38.19%   +0.02%     
- Complexity     4666     4673       +7     
============================================
  Files          1278     1278              
  Lines         44479    44481       +2     
  Branches       4783     4783              
============================================
+ Hits          16978    16988      +10     
+ Misses        25639    25631       -8     
  Partials       1862     1862              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 14272da into apache:dev Dec 6, 2023
@ruanwenjun ruanwenjun deleted the dev_wenjun_moveDelayToMaster branch November 23, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants