[Feature-15248][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice #15248

xujiaqiang · 2023-11-30T09:07:13Z

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

[Feature][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice #15170

…q-alert-voice # Conflicts: # dolphinscheduler-bom/pom.xml

…q-alert-voice # Conflicts: # dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertInputTips.java # dolphinscheduler-alert/dolphinscheduler-alert-plugins/pom.xml # dolphinscheduler-ui/src/locales/en_US/security.ts # dolphinscheduler-ui/src/locales/zh_CN/security.ts

…q-alert-voice

xujiaqiang · 2023-12-04T06:05:32Z

Looks like still run tools/dependencies/check-LICENSE.sh error

I ran tools/dependencies/check LICENSE.sh locally without any errors, is it not my problem here? @qingwli

qingwli · 2023-12-04T10:02:18Z

I have test and works well locally, please help check @zhongjiajie

zhongjiajie

You have to change and add two more sections in

dolphinscheduler/docs/configs/docsdev.js

Lines 407 to 410 in 0c470ff

    
           { 
        
               title: 'Slack', 
        
               link: '/en-us/docs/dev/user_doc/guide/alert/slack.html', 
        
           },

and

dolphinscheduler/docs/configs/docsdev.js

Lines 1120 to 1123 in 0c470ff

    
           { 
        
               title: 'Slack告警', 
        
               link: '/zh-cn/docs/dev/user_doc/guide/alert/slack.html', 
        
           },

because you add two new files in the docs. Others LGTM

…v-xjq-alert-voice-new

qingwli

LGTM @zhongjiajie PTAL

davidzollo

+1
LGTM

SbloodyS

You should add newly dependenies to https://github.com/apache/dolphinscheduler/blob/dev/tools/dependencies/known-dependencies.txt. @xujiaqiang

dolphinscheduler-alert/dolphinscheduler-alert-plugins/pom.xml

…v-xjq-alert-voice-new

sonarqubecloud · 2023-12-13T07:52:16Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
60.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

SbloodyS

+1

Fixed.

@DaTa

fix typo bug in JSONUtils.java add DBType dolphindb spotless apply & modify ui fix mvn package OK TO DO: Modify DolphinDBDataSourceProcessor fix datasource bug -> connect OK [Improvement-15260][dolphinscheduler-datasource-hana] add hana related dependencies (apache#15260) * add hana related dependencies * optimizing HANA data source bugs * run mvn spotless:apply * Fix hana datasource getValidationQuery() * Fix hana datasource testGetJdbcUrl() --------- Co-authored-by: xujiaqiang <“[email protected]”> Co-authored-by: David Zollo <[email protected]> [Feature-15248][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice (apache#15248) * add alert aliyun-voice * VoiceParam replace these with lombok @DaTa * security.ts add alarm_instance params * optimize alert aliyun vocie code * Merge Code * rollback pnpm-lock.yaml to branch :origin/dev version * add the doc about the new plugin * add com.aliyun.dyvmsapi20170525 version 2.14 * completed * run mvn spotless:apply * Code optimization * Change to @DaTa * Code specification optimization * add com.aliyund.yvmsapi20170525.jar license * modify com.aliyund.yvmsapi20170525.jar license * modify com.aliyund.yvmsapi20170525.jar license * add aliyun-vocie licenses * add aliyun-voice link to docsdev.js * modify vocie module to aliyunVoice * add lisense --------- Co-authored-by: xujiaqiang <“[email protected]”> Co-authored-by: 旺阳 <[email protected]> Co-authored-by: David Zollo <[email protected]> [Feature-15146][dolphinscheduler-task-sqoop] add sqoop source/target type (apache#15146) * task list: sgoop node params optimize * security.ts add alarm_instance params * 1 add SqoopTask params 2 add alert plugin aliyun-voice * add license header * commit sqhoop optimize * pnpm-locl.yaml supplement annotation * remove irrelevent commit. * Code specification optimization * optimize sqoop task ui * Merge Code * add the license header to pnpm-locl.yaml * format the code * format the code * Fix sqoop task echo error --------- Co-authored-by: xujiaqiang <[email protected]> Co-authored-by: xujiaqiang <“[email protected]”> Co-authored-by: David Zollo <[email protected]> finishgit add dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/DataSourceConstants.java Fix k8sTaskExecutionContext setting configYaml (apache#15116) * fixed the issue of obtaining kubeConfig of k8s tasks * removed excess files * removed excess files * formatted the code --------- Co-authored-by: xiangzihao <[email protected]> Co-authored-by: Aaron Wang <[email protected]>

@DaTa

fix typo bug in JSONUtils.java add DBType dolphindb spotless apply & modify ui fix mvn package OK TO DO: Modify DolphinDBDataSourceProcessor fix datasource bug -> connect OK [Improvement-15260][dolphinscheduler-datasource-hana] add hana related dependencies (apache#15260) * add hana related dependencies * optimizing HANA data source bugs * run mvn spotless:apply * Fix hana datasource getValidationQuery() * Fix hana datasource testGetJdbcUrl() --------- Co-authored-by: xujiaqiang <“[email protected]”> Co-authored-by: David Zollo <[email protected]> [Feature-15248][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice (apache#15248) * add alert aliyun-voice * VoiceParam replace these with lombok @DaTa * security.ts add alarm_instance params * optimize alert aliyun vocie code * Merge Code * rollback pnpm-lock.yaml to branch :origin/dev version * add the doc about the new plugin * add com.aliyun.dyvmsapi20170525 version 2.14 * completed * run mvn spotless:apply * Code optimization * Change to @DaTa * Code specification optimization * add com.aliyund.yvmsapi20170525.jar license * modify com.aliyund.yvmsapi20170525.jar license * modify com.aliyund.yvmsapi20170525.jar license * add aliyun-vocie licenses * add aliyun-voice link to docsdev.js * modify vocie module to aliyunVoice * add lisense --------- Co-authored-by: xujiaqiang <“[email protected]”> Co-authored-by: 旺阳 <[email protected]> Co-authored-by: David Zollo <[email protected]> [Feature-15146][dolphinscheduler-task-sqoop] add sqoop source/target type (apache#15146) * task list: sgoop node params optimize * security.ts add alarm_instance params * 1 add SqoopTask params 2 add alert plugin aliyun-voice * add license header * commit sqhoop optimize * pnpm-locl.yaml supplement annotation * remove irrelevent commit. * Code specification optimization * optimize sqoop task ui * Merge Code * add the license header to pnpm-locl.yaml * format the code * format the code * Fix sqoop task echo error --------- Co-authored-by: xujiaqiang <[email protected]> Co-authored-by: xujiaqiang <“[email protected]”> Co-authored-by: David Zollo <[email protected]> finishgit add dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/DataSourceConstants.java Fix k8sTaskExecutionContext setting configYaml (apache#15116) * fixed the issue of obtaining kubeConfig of k8s tasks * removed excess files * removed excess files * formatted the code --------- Co-authored-by: xiangzihao <[email protected]> Co-authored-by: Aaron Wang <[email protected]>

xujiaqiang and others added 28 commits July 25, 2023 22:45

add alert aliyun-voice

95271bd

VoiceParam replace these with lombok @DaTa

1a06741

security.ts add alarm_instance params

7257d9e

Merge remote-tracking branch 'origin/dev-xjq-alert-voice' into dev-xj…

38656a2

…q-alert-voice # Conflicts: # dolphinscheduler-bom/pom.xml

optimize alert aliyun vocie code

8ebd3df

Merge Code

ae9867a

rollback pnpm-lock.yaml to branch :origin/dev version

60bd96f

Merge branch 'dev' into dev-xjq-alert-voice

0388371

Merge branch 'dev' into dev-xjq-alert-voice

d40eb7c

add the doc about the new plugin

97fcbbc

Merge remote-tracking branch 'origin/dev-xjq-alert-voice' into dev-xj…

c7e5789

…q-alert-voice

Merge branch 'dev' into dev-xjq-alert-voice

b68b109

Merge branch 'dev' into dev-xjq-alert-voice

c3f016a

add com.aliyun.dyvmsapi20170525 version 2.14

7d25efc

Merge branch 'dev' into dev-xjq-alert-voice

911e8f8

completed

bccade1

Merge branch 'dev' into dev-xjq-alert-voice

7d1a36e

run mvn spotless:apply

97f4c81

Code optimization

e6b975d

Merge branch 'dev' into dev-xjq-alert-voice

79bb89a

Change to @DaTa

d0a3854

Code specification optimization

a7749ff

add com.aliyund.yvmsapi20170525.jar license

4bfb463

Merge branch 'dev' into dev-xjq-alert-voice

f65a547

modify com.aliyund.yvmsapi20170525.jar license

6600b64

Merge remote-tracking branch 'origin/dev-xjq-alert-voice' into dev-xj…

22ebf22

…q-alert-voice

modify com.aliyund.yvmsapi20170525.jar license

52af060

xujiaqiang requested review from EricGao888 and zhongjiajie as code owners November 30, 2023 09:07

Merge branch 'dev' into dev-xjq-alert-voice-new

21a3454

zhongjiajie added the first time contributor First-time contributor label Dec 9, 2023

zhongjiajie previously requested changes Dec 9, 2023

View reviewed changes

xujiaqiang added 2 commits December 11, 2023 08:51

add aliyun-voice link to docsdev.js

b42bb5a

Merge remote-tracking branch 'origin/dev-xjq-alert-voice-new' into de…

ef6c56b

…v-xjq-alert-voice-new

xujiaqiang requested a review from zhongjiajie December 11, 2023 00:53

Merge branch 'dev' into dev-xjq-alert-voice-new

3e496de

qingwli previously approved these changes Dec 11, 2023

View reviewed changes

Merge branch 'dev' into dev-xjq-alert-voice-new

272e3c4

davidzollo previously approved these changes Dec 12, 2023

View reviewed changes

davidzollo added feature new feature ready-to-merge labels Dec 12, 2023

SbloodyS reviewed Dec 13, 2023

View reviewed changes

dolphinscheduler-alert/dolphinscheduler-alert-plugins/pom.xml Outdated Show resolved Hide resolved

xujiaqiang added 2 commits December 13, 2023 12:10

modify vocie module to aliyunVoice

b851d07

Merge remote-tracking branch 'origin/dev-xjq-alert-voice-new' into de…

31b987a

…v-xjq-alert-voice-new

xujiaqiang dismissed stale reviews from davidzollo and qingwli via 31b987a December 13, 2023 04:11

add lisense

e62c9f0

SbloodyS assigned xujiaqiang Dec 13, 2023

SbloodyS added the 3.3.0 label Dec 13, 2023

SbloodyS added this to the 3.3.0 milestone Dec 13, 2023

SbloodyS approved these changes Dec 13, 2023

View reviewed changes

SbloodyS merged commit d144f48 into apache:dev Dec 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Feature-15248][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice #15248

[Feature-15248][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice #15248

Uh oh!

xujiaqiang commented Nov 30, 2023 •

edited

Loading

Uh oh!

xujiaqiang commented Dec 4, 2023 •

edited

Loading

Uh oh!

qingwli commented Dec 4, 2023

Uh oh!

zhongjiajie left a comment

Uh oh!

qingwli left a comment

Uh oh!

davidzollo left a comment

Uh oh!

SbloodyS left a comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Dec 13, 2023

Uh oh!

SbloodyS left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

	{
	title: 'Slack',
	link: '/en-us/docs/dev/user_doc/guide/alert/slack.html',
	},

	{
	title: 'Slack告警',
	link: '/zh-cn/docs/dev/user_doc/guide/alert/slack.html',
	},

[Feature-15248][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice #15248

[Feature-15248][dolphinscheduler-alert-plugins] add alert plugin aliyun-voice #15248

Uh oh!

Conversation

xujiaqiang commented Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of the pull request

Brief change log

Verify this pull request

Uh oh!

xujiaqiang commented Dec 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qingwli commented Dec 4, 2023

Uh oh!

zhongjiajie left a comment

Choose a reason for hiding this comment

Uh oh!

qingwli left a comment

Choose a reason for hiding this comment

Uh oh!

davidzollo left a comment

Choose a reason for hiding this comment

Uh oh!

SbloodyS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Dec 13, 2023

Quality Gate passed

Uh oh!

SbloodyS left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

xujiaqiang commented Nov 30, 2023 •

edited

Loading

xujiaqiang commented Dec 4, 2023 •

edited

Loading