Skip to content

Conversation

@ruanwenjun
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (4c56acb) 38.03% compared to head (f22d76f) 37.98%.

❗ Current head f22d76f differs from pull request most recent head b60193e. Consider uploading reports for the commit b60193e to get more accurate results

Files Patch % Lines
...pache/dolphinscheduler/common/utils/FileUtils.java 0.00% 11 Missing ⚠️
...server/worker/utils/TaskExecutionCheckerUtils.java 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15240      +/-   ##
============================================
- Coverage     38.03%   37.98%   -0.05%     
+ Complexity     4649     4638      -11     
============================================
  Files          1279     1279              
  Lines         44501    44505       +4     
  Branches       4796     4799       +3     
============================================
- Hits          16924    16907      -17     
- Misses        25717    25738      +21     
  Partials       1860     1860              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ruanwenjun ruanwenjun added ready-to-merge improvement make more easy to user or prompt friendly labels Nov 29, 2023
@ruanwenjun ruanwenjun merged commit f2d1466 into apache:dev Nov 29, 2023
@ruanwenjun ruanwenjun deleted the dev_wenjun_uselinuxCommandToSetTenant branch November 29, 2023 08:28
@SbloodyS SbloodyS added the 3.2.1 label Dec 27, 2023
@SbloodyS SbloodyS added this to the 3.2.1 milestone Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.2.1 backend improvement make more easy to user or prompt friendly ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants