Skip to content

[Fix] Change HTTP plugin timeout param to number type #15234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qingwli merged 1 commit into from
Nov 28, 2023
Merged

[Fix] Change HTTP plugin timeout param to number type #15234

qingwli merged 1 commit into from
Nov 28, 2023

Conversation

@qingwli
Copy link
Member

@qingwli qingwli commented Nov 28, 2023

No description provided.

@qingwli qingwli requested a review from caishunfeng as a code owner November 28, 2023 07:36
@qingwli qingwli self-assigned this Nov 28, 2023
@qingwli qingwli added this to the 3.3.0 milestone Nov 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5eddc0) 38.02% compared to head (1c9ebcb) 38.01%.

❗ Current head 1c9ebcb differs from pull request most recent head ed015fb. Consider uploading reports for the commit ed015fb to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #15234      +/-   ##
============================================
- Coverage     38.02%   38.01%   -0.02%     
+ Complexity     4645     4640       -5     
============================================
  Files          1279     1279              
  Lines         44500    44501       +1     
  Branches       4797     4797              
============================================
- Hits          16923    16917       -6     
- Misses        25717    25723       +6     
- Partials       1860     1861       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 28, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

ruanwenjun
ruanwenjun approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingwli qingwli added ready-to-merge bug Something isn't working labels Nov 28, 2023
@qingwli qingwli merged commit 4c56acb into apache:dev Nov 28, 2023
@qingwli qingwli deleted the http-plugin-fix branch November 28, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng

Assignees

@qingwli qingwli

Labels

backend bug Something isn't working ready-to-merge

Projects

None yet

Milestone

3.3.0-alpha

Development

Successfully merging this pull request may close these issues.

3 participants

@qingwli @codecov-commenter @ruanwenjun