Skip to content

[Bug] fix switch condition #15228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
caishunfeng merged 2 commits into from
Nov 27, 2023
Merged

[Bug] fix switch condition #15228

caishunfeng merged 2 commits into from
Nov 27, 2023

Conversation

@caishunfeng
Copy link
Contributor

@caishunfeng caishunfeng commented Nov 26, 2023

Purpose of the pull request

add switch args check to avoid illegal condition.

Brief change log

  • SwitchLogicTask

Verify this pull request

  • Added UT SwitchTaskUtilsTest

@caishunfeng caishunfeng self-assigned this Nov 26, 2023
@caishunfeng caishunfeng added bug Something isn't working 3.1.x for 3.1.x version backend and removed backend labels Nov 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023 •
edited
Loading

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (12f8138) 37.99% compared to head (2c8088f) 38.02%.

❗ Current head 2c8088f differs from pull request most recent head f8a412f. Consider uploading reports for the commit f8a412f to get more accurate results

Files Patch % Lines
...master/runner/task/switchtask/SwitchLogicTask.java 0.00% 10 Missing ⚠️
...scheduler/server/master/utils/SwitchTaskUtils.java 69.23% 3 Missing and 5 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #15228      +/-   ##
============================================
+ Coverage     37.99%   38.02%   +0.03%     
- Complexity     4640     4645       +5     
============================================
  Files          1279     1279              
  Lines         44490    44500      +10     
  Branches       4794     4797       +3     
============================================
+ Hits          16902    16923      +21     
+ Misses        25733    25717      -16     
- Partials       1855     1860       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 5 Code Smells

63.0% 63.0% Coverage
0.0% 0.0% Duplication

zhongjiajie
zhongjiajie approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@caishunfeng caishunfeng merged commit b5eddc0 into apache:dev Nov 27, 2023
@caishunfeng caishunfeng deleted the fix/switch_condition branch November 27, 2023 06:03
@zhongjiajie zhongjiajie added this to the 3.1.9 milestone Dec 5, 2023
caishunfeng added a commit to caishunfeng/dolphinscheduler that referenced this pull request Dec 19, 2023
@caishunfeng @EricGao888
fix switch condition (apache#15228)
47ed2c9 
Co-authored-by: Eric Gao <[email protected]>
@caishunfeng caishunfeng mentioned this pull request Dec 19, 2023
Merged
zhuangchong pushed a commit that referenced this pull request Dec 19, 2023
@caishunfeng
fix switch condition (#15228) (#15336)
61d9795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

Assignees

@caishunfeng caishunfeng

Labels

3.1.x for 3.1.x version backend bug Something isn't working ready-to-merge

Projects

None yet

Milestone

3.1.9

Development

Successfully merging this pull request may close these issues.

4 participants

@caishunfeng @codecov-commenter @zhongjiajie @EricGao888