Skip to content

[Bug][force-success] force success add end time #15144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rickchengx merged 2 commits into from
Feb 5, 2024
Merged

[Bug][force-success] force success add end time #15144

rickchengx merged 2 commits into from
Feb 5, 2024

Conversation

@sdhzwc
Copy link
Contributor

@sdhzwc sdhzwc commented Nov 8, 2023

Purpose of the pull request

fix:#15142

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@mergeable mergeable bot removed the backend label Nov 8, 2023
@SbloodyS SbloodyS added bug Something isn't working backend 3.2.1 labels Nov 8, 2023
@SbloodyS SbloodyS added this to the 3.2.1 milestone Nov 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8e820c) 38.38% compared to head (2870e20) 38.38%.

❗ Current head 2870e20 differs from pull request most recent head 03b70ae. Consider uploading reports for the commit 03b70ae to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##                dev   #15144   +/-   ##
=========================================
  Coverage     38.38%   38.38%           
  Complexity     4747     4747           
=========================================
  Files          1305     1305           
  Lines         44846    44847    +1     
  Branches       4810     4810           
=========================================
+ Hits          17213    17214    +1     
  Misses        25759    25759           
  Partials       1874     1874

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fuchanghai
fuchanghai approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ruanwenjun
ruanwenjun reviewed Nov 19, 2023
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, this pr basically LGTM, could you use English to describe this problem in issue #15142. And UT is needed.

@ruanwenjun ruanwenjun added the miss:tests missing unit tests in PR label Nov 19, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

rickchengx
rickchengx approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this pr has been stale for several months, I would like to add related UT in another pr after it is merged.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rickchengx rickchengx dismissed EricGao888’s stale review February 5, 2024 06:21

It seems that this pr has been stale for several months, I would like to add related UT in another pr after it is merged.

@rickchengx rickchengx merged commit e5a208f into apache:dev Feb 5, 2024
@rickchengx rickchengx mentioned this pull request Feb 5, 2024
Merged
zhongjiajie pushed a commit that referenced this pull request Feb 6, 2024
@sdhzwc @rickchengx @zhongjiajie
[Bug][force-success] force success add end time (#15144)
7d660ec 
Co-authored-by: Rick Cheng <[email protected]>
(cherry picked from commit e5a208f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruanwenjun ruanwenjun ruanwenjun left review comments

@qingwli qingwli qingwli approved these changes

@fuchanghai fuchanghai fuchanghai approved these changes

@rickchengx rickchengx rickchengx approved these changes

@EricGao888 EricGao888 EricGao888 left review comments

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

Assignees

@sdhzwc sdhzwc

Labels

3.2.1 backend bug Something isn't working miss:tests missing unit tests in PR ready-to-merge

Projects

None yet

Milestone

3.2.1

Development

Successfully merging this pull request may close these issues.

8 participants

@sdhzwc @codecov-commenter @qingwli @ruanwenjun @fuchanghai @EricGao888 @rickchengx @SbloodyS