Skip to content

Conversation

@Radeity
Copy link
Member

@Radeity Radeity commented Oct 31, 2023

Purpose of the pull request

Brief change log

Before
image

After
image

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Radeity Radeity added bug Something isn't working 3.2.1 labels Oct 31, 2023
@Radeity Radeity added this to the 3.2.1 milestone Oct 31, 2023
@Radeity Radeity self-assigned this Oct 31, 2023
@Radeity Radeity changed the title [Bug-15072][Resource Center] Non-admin user can not query resource recursively [Fix-15072][Resource Center] Non-admin user can not query resource recursively Oct 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #15097 (a002ecc) into dev (d5f99cc) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head a002ecc differs from pull request most recent head 23024f1. Consider uploading reports for the commit 23024f1 to get more accurate results

@@             Coverage Diff              @@
##                dev   #15097      +/-   ##
============================================
- Coverage     38.24%   38.21%   -0.03%     
+ Complexity     4699     4697       -2     
============================================
  Files          1280     1280              
  Lines         45410    45411       +1     
  Branches       4951     4952       +1     
============================================
- Hits          17365    17355      -10     
- Misses        26151    26163      +12     
+ Partials       1894     1893       -1     
Files Coverage Δ
...heduler/api/service/impl/ResourcesServiceImpl.java 42.75% <0.00%> (-0.06%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Radeity
Copy link
Member Author

Radeity commented Nov 1, 2023

Hi @Gallardot , can you help check the CI error when free?

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Radeity Radeity merged commit dc503b0 into apache:dev Nov 2, 2023
@Radeity Radeity deleted the Bug-15072 branch November 2, 2023 05:34
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When a non-admin account uploads files in the resource center, the workflow definition Spark type task main package cannot be referenced.

3 participants