Skip to content

[fix-#11726] fix error when set connection proerty both in the URL an… #15093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SbloodyS merged 3 commits into from
Nov 3, 2023
Merged

[fix-#11726] fix error when set connection proerty both in the URL an… #15093

SbloodyS merged 3 commits into from
Nov 3, 2023

Conversation

@izualzhy
Copy link
Contributor

@izualzhy izualzhy commented Oct 29, 2023

close issue-11726

@izualzhy izualzhy requested a review from caishunfeng as a code owner October 29, 2023 12:16
@SbloodyS SbloodyS added bug Something isn't working first time contributor First-time contributor 3.1.x for 3.1.x version 3.2.1 labels Oct 30, 2023
@SbloodyS SbloodyS added this to the 3.2.1 milestone Oct 30, 2023
SbloodyS
SbloodyS approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023 •
edited
Loading

Codecov Report

Merging #15093 (e277815) into dev (dc503b0) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head e277815 differs from pull request most recent head 771dc37. Consider uploading reports for the commit 771dc37 to get more accurate results

@@            Coverage Diff            @@
##                dev   #15093   +/-   ##
=========================================
  Coverage     38.21%   38.22%           
+ Complexity     4698     4694    -4     
=========================================
  Files          1280     1280           
  Lines         45411    45408    -3     
  Branches       4952     4953    +1     
=========================================
  Hits          17356    17356           
+ Misses        26162    26160    -2     
+ Partials       1893     1892    -1
Files Coverage Δ
...source/presto/param/PrestoDataSourceProcessor.java 50.00% <ø> (+3.33%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SbloodyS SbloodyS merged commit 8665951 into apache:dev Nov 3, 2023
@ruanwenjun ruanwenjun mentioned this pull request Mar 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SbloodyS SbloodyS SbloodyS approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng

Assignees

@izualzhy izualzhy

Labels

3.1.x for 3.1.x version 3.2.1 backend bug Something isn't working first time contributor First-time contributor ready-to-merge

Projects

None yet

Milestone

3.2.1

Development

Successfully merging this pull request may close these issues.

[Bug] [dolphinscheduler-api] create presto datasource failed with extra "jdbc connect parameters"

3 participants

@izualzhy @codecov-commenter @SbloodyS