Fix SqlTask cannot split the given sql when browser in windows #15062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
SbloodyS,
caishunfeng and
zhuangchong
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_fixMultipleSqlInWindows
branch
from
e3fe4e1 to
a46488e
Compare
Codecov Report
@@ Coverage Diff @@
## dev #15062 +/- ##
============================================
+ Coverage 37.74% 37.76% +0.01%
- Complexity 4588 4591 +3
============================================
Files 1247 1248 +1
Lines 44714 44711 -3
Branches 4913 4912 -1
============================================
+ Hits 16877 16884 +7
+ Misses 25959 25949 -10
Partials 1878 1878
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
ruanwenjun
force-pushed
the
dev_wenjun_fixMultipleSqlInWindows
branch
from
a46488e to
760cf3c
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fixMultipleSqlInWindows
branch
from
760cf3c to
8dc8969
Compare
|
SonarCloud Quality Gate failed.
|
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #15048
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md