[Bug] remove sub workflow finish notify #15057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caishunfeng
added
bug
Codecov Report
@@ Coverage Diff @@
## dev #15057 +/- ##
============================================
+ Coverage 38.95% 39.00% +0.05%
+ Complexity 4603 4599 -4
============================================
Files 1231 1231
Lines 43356 43300 -56
Branches 4794 4792 -2
============================================
Hits 16888 16888
+ Misses 24592 24536 -56
Partials 1876 1876
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 30, 2023
Co-authored-by: xiangzihao <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
When multiple masters are used to run sub-workflow tasks, notification may cause memory data inconsistency in the parent workflow instance, and the process will be more complicated.
Currently, relying on
StateWheelExecuteThreadto trigger states events is simple and efficient enough.Brief change log
WorkflowExecuteThreadPoolVerify this pull request