Skip to content

Conversation

@ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Oct 12, 2023

Purpose of the pull request

In order to expanding database, it's needed to add dolphinscheduler-dao-plugin module, extract the database config logic to this module.

Brief change log

  • Add dolphinscheduler-dao-plugin and move mysql/h2/postgresql to submodule.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addDaoPlugin branch from 8777c14 to ae17f7d Compare October 12, 2023 12:52
@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Oct 12, 2023
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addDaoPlugin branch 14 times, most recently from 0d1a5d1 to 74892e6 Compare October 13, 2023 08:51
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #15019 (eea1791) into dev (a9a621f) will increase coverage by 0.04%.
Report is 1 commits behind head on dev.
The diff coverage is 57.14%.

❗ Current head eea1791 differs from pull request most recent head 483aab7. Consider uploading reports for the commit 483aab7 to get more accurate results

@@             Coverage Diff              @@
##                dev   #15019      +/-   ##
============================================
+ Coverage     38.91%   38.95%   +0.04%     
+ Complexity     4612     4610       -2     
============================================
  Files          1236     1232       -4     
  Lines         43449    43360      -89     
  Branches       4809     4795      -14     
============================================
- Hits          16907    16890      -17     
+ Misses        24668    24597      -71     
+ Partials       1874     1873       -1     
Files Coverage Δ
...scheduler/api/service/impl/MonitorServiceImpl.java 94.87% <100.00%> (-0.13%) ⬇️
...eduler/dao/datasource/SpringConnectionFactory.java 100.00% <100.00%> (+6.06%) ⬆️
...scheduler/common/sql/ClasspathSqlScriptParser.java 76.27% <25.00%> (-3.73%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addDaoPlugin branch 8 times, most recently from c71fcc3 to c5dedc0 Compare October 14, 2023 06:35
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addDaoPlugin branch from c5dedc0 to 483aab7 Compare October 14, 2023 07:10
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

7.4% 7.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Radeity Radeity added this to the 3.2.1 milestone Oct 14, 2023
@ruanwenjun ruanwenjun merged commit 33084d2 into apache:dev Oct 14, 2023
@ruanwenjun ruanwenjun deleted the dev_wenjun_addDaoPlugin branch October 14, 2023 09:58
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.2.1 backend improvement make more easy to user or prompt friendly major ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants