Skip to content

Conversation

@qingwli qingwli added this to the 3.3.0 milestone Oct 8, 2023
@qingwli qingwli self-assigned this Oct 8, 2023
@qingwli qingwli added the bug Something isn't working label Oct 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2023

Codecov Report

Merging #14992 (da8725b) into dev (65a7c7f) will decrease coverage by 0.01%.
The diff coverage is 71.42%.

❗ Current head da8725b differs from pull request most recent head fee5d1a. Consider uploading reports for the commit fee5d1a to get more accurate results

@@             Coverage Diff              @@
##                dev   #14992      +/-   ##
============================================
- Coverage     38.19%   38.19%   -0.01%     
  Complexity     4683     4683              
============================================
  Files          1281     1281              
  Lines         45347    45347              
  Branches       4941     4941              
============================================
- Hits          17321    17320       -1     
  Misses        26138    26138              
- Partials       1888     1889       +1     
Files Coverage Δ
...nscheduler/api/service/impl/DqRuleServiceImpl.java 59.18% <100.00%> (ø)
...cheduler/plugin/task/dq/utils/RuleParserUtils.java 87.03% <100.00%> (ø)
...apache/dolphinscheduler/dao/utils/DqRuleUtils.java 0.00% <0.00%> (ø)
...inscheduler/plugin/task/api/enums/dp/DataType.java 88.88% <85.71%> (ø)
...er/runner/execute/TaskExecutionContextFactory.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM.

qE0a44OX6s and others added 5 commits October 11, 2023 01:14
# Conflicts:
#	dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/mysql/dolphinscheduler_ddl.sql
#	dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/postgresql/dolphinscheduler_ddl.sql
@qingwli
Copy link
Member Author

qingwli commented Nov 9, 2023

PTAL @Radeity @zixi0825

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

82.8% 82.8% Coverage
0.0% 0.0% Duplication

@qingwli qingwli merged commit 5afd941 into apache:dev Nov 13, 2023
@qingwli qingwli deleted the data-quality-fix branch November 13, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants