Skip to content

[Feature][Helm] Supports deploying only partial components #14985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SbloodyS merged 5 commits into from
Oct 10, 2023
Merged

[Feature][Helm] Supports deploying only partial components #14985

SbloodyS merged 5 commits into from
Oct 10, 2023

Conversation

@Gallardot
Copy link
Member

@Gallardot Gallardot commented Oct 7, 2023

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Gallardot Gallardot requested a review from caishunfeng as a code owner October 7, 2023 08:41
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023 •
edited
Loading

Codecov Report

Merging #14985 (bdf3036) into dev (049c151) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head bdf3036 differs from pull request most recent head 4e599a6. Consider uploading reports for the commit 4e599a6 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14985      +/-   ##
============================================
- Coverage     38.91%   38.89%   -0.02%     
+ Complexity     4611     4610       -1     
============================================
  Files          1236     1236              
  Lines         43439    43439              
  Branches       4807     4807              
============================================
- Hits          16903    16895       -8     
- Misses        24662    24672      +10     
+ Partials       1874     1872       -2

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SbloodyS SbloodyS added this to the 3.2.1 milestone Oct 8, 2023
@SbloodyS SbloodyS requested a review from Radeity October 8, 2023 08:43
Radeity
Radeity reviewed Oct 8, 2023
View reviewed changes
Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docs about these new configuration, and I suggest to add some statement to let user know they have to define different release name when executing helm install.

@Radeity Radeity added the miss:docs missing documents in PR label Oct 8, 2023
@Gallardot
chore: add doc
7281e62 
Signed-off-by: Gallardot <[email protected]>
@github-actions github-actions bot added document and removed backend labels Oct 9, 2023
@Gallardot
Copy link
Member Author

Gallardot commented Oct 9, 2023

Missing docs about these new configuration, and I suggest to add some statement to let user know they have to define different release name when executing helm install.

Done. PTAL. @Radeity

PS: To change the current values.yaml, we need to manually modify the Chinese and English documents. We are expected to automatically generate them later. I've set up an issue #14720

@Gallardot
chore: miss some doc
4e599a6 
Signed-off-by: Gallardot <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Radeity Radeity added ready-to-merge and removed miss:docs missing documents in PR labels Oct 9, 2023
SbloodyS
SbloodyS approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS merged commit 4fe41ac into apache:dev Oct 10, 2023
@Gallardot Gallardot deleted the worker-single branch October 11, 2023 01:46
qingwli pushed a commit to qingwli/dolphinscheduler that referenced this pull request Oct 11, 2023
@Gallardot @qingwli
[Feature][Helm] Supports deploying only partial components (apache#14985
c580716 
)

* [Feature][Helm] Supports deploying only partial components

* chore: add doc

* chore: miss some doc
@zhongjiajie zhongjiajie removed this from the 3.2.1 milestone Oct 11, 2023
@zhongjiajie zhongjiajie added this to the 3.2.0 milestone Oct 11, 2023
zhongjiajie pushed a commit that referenced this pull request Oct 11, 2023
@Gallardot @zhongjiajie
[Feature][Helm] Supports deploying only partial components (#14985)
7b43c66 
* [Feature][Helm] Supports deploying only partial components

* chore: add doc

* chore: miss some doc

(cherry picked from commit 4fe41ac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SbloodyS SbloodyS SbloodyS approved these changes

@Radeity Radeity Radeity approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

Assignees

@Gallardot Gallardot

Labels

3.2.1 document feature new feature kubernetes ready-to-merge

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

[Feature][Helm] Supports deploying only partial components.

5 participants

@Gallardot @codecov-commenter @SbloodyS @Radeity @zhongjiajie