[DSIP-19] Support sagemaker connections in the connection center, as well as external connections to the connection center in sagemaker tasks #14976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l connections in zeppelin tasks
songjianet
previously approved these changes
Oct 30, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| import com.fasterxml.jackson.annotation.JsonInclude; | ||
|
|
||
| @Data |
Check notice
Code scanning / CodeQL
Missing Override annotation
|
|
||
| protected String userName; | ||
|
|
||
| protected String password; |
Check notice
Code scanning / CodeQL
Missing Override annotation
...g/apache/dolphinscheduler/plugin/datasource/sagemaker/param/SagemakerDataSourceParamDTO.java
Fixed
Show fixed
Hide fixed
...g/apache/dolphinscheduler/plugin/datasource/sagemaker/param/SagemakerDataSourceParamDTO.java
Fixed
Show fixed
Hide fixed
...g/apache/dolphinscheduler/plugin/datasource/sagemaker/param/SagemakerDataSourceParamDTO.java
Fixed
Show fixed
Hide fixed
...g/apache/dolphinscheduler/plugin/datasource/sagemaker/param/SagemakerDataSourceParamDTO.java
Fixed
Show fixed
Hide fixed
...g/apache/dolphinscheduler/plugin/datasource/sagemaker/param/SagemakerDataSourceParamDTO.java
Fixed
Show fixed
Hide fixed
...ker/src/main/java/org/apache/dolphinscheduler/plugin/task/sagemaker/SagemakerParameters.java
Fixed
Show fixed
Hide fixed
Member
|
@xdu-chenrj You may try something like |
EricGao888
approved these changes
Oct 30, 2023
|
Kudos, SonarCloud Quality Gate passed! |
EricGao888
added
3.3.0
ready-to-merge
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #14338
Related issues: [DSIP-19][Feature] Add connection center feature for DS #10283
Mail: https://lists.apache.org/thread/xl6pb3sbrt0ffrf1fltcph39s9w1pjlx