Skip to content

Conversation

@imp2002
Copy link
Contributor

@imp2002 imp2002 commented Sep 10, 2023

Purpose of the pull request

Fix: #14885

Brief change log

fix spotless format file path

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Merging #14889 (091fd1f) into dev (28788c7) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 091fd1f differs from pull request most recent head b7da34e. Consider uploading reports for the commit b7da34e to get more accurate results

@@             Coverage Diff              @@
##                dev   #14889      +/-   ##
============================================
- Coverage     38.96%   38.95%   -0.02%     
- Complexity     4599     4604       +5     
============================================
  Files          1231     1231              
  Lines         43354    43354              
  Branches       4795     4793       -2     
============================================
- Hits          16893    16888       -5     
- Misses        24585    24594       +9     
+ Partials       1876     1872       -4     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SbloodyS SbloodyS requested a review from EricGao888 September 12, 2023 07:23
@SbloodyS SbloodyS added bug Something isn't working 3.2.1 labels Sep 12, 2023
@SbloodyS SbloodyS added this to the 3.2.1 milestone Sep 12, 2023
@EricGao888 EricGao888 modified the milestones: 3.2.1, 3.3.0 Sep 28, 2023
@EricGao888 EricGao888 added 3.3.0 improvement make more easy to user or prompt friendly and removed 3.2.1 bug Something isn't working labels Sep 28, 2023
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SbloodyS SbloodyS merged commit 8f16fd7 into apache:dev Oct 17, 2023
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 30, 2023
* fix: fix `spotless` format file path

* fix: remove duplicate dependencies

---------

Co-authored-by: Eric Gao <[email protected]>
Co-authored-by: Aaron Wang <[email protected]>
Co-authored-by: xiangzihao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.3.0 backend improvement make more easy to user or prompt friendly ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] mvn package error, coun't find spotless path

5 participants