[Improvement] [Task] Change Seatunnel task run-mode to deploy-mode #14800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangbaipeng
requested review from
SbloodyS,
caishunfeng and
zhuangchong
as code owners
Member
|
Basically LGTM, please update the doc, and it's better to add the support seatunnel version in doc. |
ruanwenjun
changed the title
zhongjiajie
previously approved these changes
Aug 24, 2023
Codecov Report
@@ Coverage Diff @@
## dev #14800 +/- ##
=========================================
Coverage 38.91% 38.92%
- Complexity 4597 4598 +1
=========================================
Files 1232 1232
Lines 43271 43271
Branches 4790 4790
=========================================
+ Hits 16841 16842 +1
Misses 24563 24563
+ Partials 1867 1866 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhongjiajie
approved these changes
Aug 30, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
zhuangchong
added
the
release cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14376
Purpose of the pull request
Seatunnel Flink parameter
The version is too low, resulting in an error: Could not get job jar and dependencies from JAR file: JAR file does not exist: --run-mode: set it to the version later than Seatunnel 2.3.x. [--deploy-mode]
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md