[RPC] Refactor the remote module. #14776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
SbloodyS,
caishunfeng and
zhuangchong
as code owners
ruanwenjun
changed the title
ruanwenjun
added
improvement
ruanwenjun
force-pushed
the
dev_wenjun_refactorRpc
branch
4 times, most recently
from
d4f3a0b to
0b9d4d9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| public interface ClientMethodInvoker { | ||
|
|
||
| Object invoke(Object proxy, Method method, Object[] args) throws Throwable; |
Check notice
Code scanning / CodeQL
Useless parameter
...e/src/main/java/org/apache/dolphinscheduler/extract/base/server/ServerMethodInvokerImpl.java
Fixed
Show fixed
Hide fixed
ruanwenjun
force-pushed
the
dev_wenjun_refactorRpc
branch
4 times, most recently
from
2bf930a to
a3bcb3d
Compare
ruanwenjun
force-pushed
the
dev_wenjun_refactorRpc
branch
6 times, most recently
from
eca3885 to
7b53548
Compare
ruanwenjun
force-pushed
the
dev_wenjun_refactorRpc
branch
from
7b53548 to
1f313aa
Compare
Codecov Report
@@ Coverage Diff @@
## dev #14776 +/- ##
============================================
- Coverage 38.85% 38.72% -0.13%
+ Complexity 4685 4502 -183
============================================
Files 1289 1198 -91
Lines 44315 42660 -1655
Branches 4880 4757 -123
============================================
- Hits 17219 16522 -697
+ Misses 25196 24311 -885
+ Partials 1900 1827 -73
... and 100 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
SonarCloud Quality Gate failed.
|
EricGao888
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #14509
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md