[Fix-14704][dao] pg not support backquote #14717
Conversation
eye-gu
force-pushed
the
Fix-14704
branch
3 times, most recently
from
12334bb to
9b0a8f8
Compare
eye-gu
force-pushed
the
Fix-14704
branch
2 times, most recently
from
35e6ece to
6bd322d
Compare
| on a.id = b.rule_input_entry_id order by b.index | ||
| </select> | ||
|
|
||
| <select id="getRuleInputEntryList" databaseId="pg" resultType="org.apache.dolphinscheduler.dao.entity.DqRuleInputEntry"> |
There was a problem hiding this comment.
Hi @eye-gu Although this is also a solution, but it means that we have to maintain two same sql.
Can this sql be splited into simple query? WDYT?
There was a problem hiding this comment.
Removing the backquote will cause unit testing to fail.
There was a problem hiding this comment.
Alternatively refer to Shenyu, which uses an Interceptor to replace backquotes with double quotes.
https://github.com/apache/shenyu/blob/master/shenyu-admin/src/main/java/org/apache/shenyu/admin/mybatis/pg/interceptor/PostgreSQLPrepareInterceptor.java
There was a problem hiding this comment.
And there is another solution is to change this column name and totally avoid questions like this
Codecov Report
@@ Coverage Diff @@
## dev #14717 +/- ##
=========================================
Coverage 38.80% 38.80%
- Complexity 4585 4586 +1
=========================================
Files 1232 1232
Lines 43318 43318
Branches 4781 4781
=========================================
+ Hits 16809 16810 +1
Misses 24650 24650
+ Partials 1859 1858 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
5 participants
Purpose of the pull request
close #14704
Brief change log
rm backquote in sql
Verify this pull request