Use AdHoc datasource client in sqlTask #14631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
EricGao888,
SbloodyS,
caishunfeng,
zhongjiajie and
zhuangchong
as code owners
ruanwenjun
added
3.2.0
mergeable
bot
removed
improvement
ruanwenjun
force-pushed
the
dev_wenjun_suportIpv6
branch
8 times, most recently
from
b732318 to
9b0250d
Compare
Codecov Report
@@ Coverage Diff @@
## dev #14631 +/- ##
============================================
+ Coverage 38.52% 38.54% +0.02%
- Complexity 4579 4583 +4
============================================
Files 1260 1279 +19
Lines 43814 43781 -33
Branches 4841 4836 -5
============================================
- Hits 16878 16876 -2
+ Misses 25061 25032 -29
+ Partials 1875 1873 -2
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ruanwenjun
force-pushed
the
dev_wenjun_suportIpv6
branch
from
9b0250d to
f9f8ed9
Compare
Member
|
related: #14626 and #14193, cc @zhuangchong |
ruanwenjun
force-pushed
the
dev_wenjun_suportIpv6
branch
4 times, most recently
from
010962d to
4adec54
Compare
ruanwenjun
force-pushed
the
dev_wenjun_suportIpv6
branch
2 times, most recently
from
694cf4a to
9d8ecf0
Compare
ruanwenjun
force-pushed
the
dev_wenjun_suportIpv6
branch
5 times, most recently
from
9ea58c4 to
ae25da7
Compare
ruanwenjun
force-pushed
the
dev_wenjun_suportIpv6
branch
from
ae25da7 to
f9cd0d6
Compare
ruanwenjun
force-pushed
the
dev_wenjun_suportIpv6
branch
from
f9cd0d6 to
08561fe
Compare
|
SonarCloud Quality Gate failed.
|
zhuangchong
added a commit
to zhuangchong/incubator-dolphinscheduler
that referenced
this pull request
Jul 28, 2023
This was referenced Jul 28, 2023
zhongjiajie
pushed a commit
that referenced
this pull request
Aug 30, 2023
* Use AdHoc datasource client in sqlTask * Add method in DataSourceChannel to create PooledDataSourceClient and AdHocDataSourceClient (cherry picked from commit 4aab0b2)
This was referenced Oct 30, 2023
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
At before discuss, we are plan to remove datasource pool in SQL task.
This PR will introduce AdHocDataSourceClient, which will not use connection pool, and keep the PooledDataSourceClient which might be useful in some query task.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md