Codecov Report

Merging #14626 (4b23ba2) into dev (930d2f0) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

❗ Current head 4b23ba2 differs from pull request most recent head 5f8fdf3. Consider uploading reports for the commit 5f8fdf3 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14626      +/-   ##
============================================
- Coverage     38.58%   38.52%   -0.07%     
- Complexity     4578     4579       +1     
============================================
  Files          1260     1260              
  Lines         43752    43808      +56     
  Branches       4830     4838       +8     
============================================
- Hits          16881    16875       -6     
- Misses        24998    25062      +64     
+ Partials       1873     1871       -2     

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruanwenjun Hi, may I ask why you want to revert this change?

@ruanwenjun Hi, may I ask why you want to revert this change?

This PR introduces some serious bugs.

1. In many drivers, the connection is not thread-safe, this pr hold one connection in CommonDataSourceClient, this will cause multiple tasks get the same connection at the same time.
2. In many drivers, connection.isClosed() is only check the closed flag at the driver side, it cannot represent if the connection is active/valided.

@ruanwenjun Hi, may I ask why you want to revert this change?

This PR introduces some serious bugs.

1. In many drivers, the connection is not thread-safe, this pr hold one connection in CommonDataSourceClient, this will cause multiple tasks get the same connection at the same time.
2. In many drivers, connection.isClosed() is only check the closed flag at the driver side, it cannot represent if the connection is active/valided.

Got it, thx for the explanation.

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

0.0% Coverage
21.6% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint