Skip to content

[Fix-14546] seatunnel unable submit spark job to spark #14617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhuangchong merged 9 commits into from
Sep 19, 2023
Merged

[Fix-14546] seatunnel unable submit spark job to spark #14617

zhuangchong merged 9 commits into from
Sep 19, 2023

Conversation

@Yhr-N
Copy link
Contributor

@Yhr-N Yhr-N commented Jul 21, 2023 •
edited by SbloodyS
Loading

Purpose of the pull request

Fix #14546

Brief change log

modified code of generating master args in org.apache.dolphinscheduler.plugin.task.seatunnel.spark.SeatunnelSparkTask: buildOptions()

Verify this pull request

This pull request is code cleanup without any test coverage.

@SbloodyS SbloodyS added bug Something isn't working 3.1.x for 3.1.x version first time contributor First-time contributor labels Jul 21, 2023
@SbloodyS SbloodyS added this to the 3.1.8 milestone Jul 21, 2023
@CallMeKingsley97
Copy link
Contributor

CallMeKingsley97 commented Jul 21, 2023 •
edited
Loading

LGTM, thanks.
https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md#pull-request-notice is usefully, not only for naming the pr. Haha😂

SbloodyS
SbloodyS reviewed Jul 21, 2023
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run mvn spotless:apply to fix format error.

@fuchanghai
Copy link
Member

fuchanghai commented Jul 25, 2023

@SbloodyS @EricGao888 @Radeity Does anyone have time to run CI for our future contributors?

@SbloodyS SbloodyS changed the title fix issue[#14546] [Fix-14546] seatunnel unable submit spark job to spark Jul 25, 2023
@SbloodyS
Copy link
Member

SbloodyS commented Jul 25, 2023

@SbloodyS @EricGao888 @Radeity Does anyone have time to run CI for our future contributors?

Done.

@Yhr-N
Copy link
Contributor Author

Yhr-N commented Jul 26, 2023

@caishunfeng @zhuangchong Please check this pr

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023 •
edited
Loading

Codecov Report

Merging #14617 (02fd8f3) into dev (298b8cc) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 02fd8f3 differs from pull request most recent head 11a459a. Consider uploading reports for the commit 11a459a to get more accurate results

@@             Coverage Diff              @@
##                dev   #14617      +/-   ##
============================================
- Coverage     38.82%   38.82%   -0.01%     
+ Complexity     4589     4588       -1     
============================================
  Files          1234     1234              
  Lines         43384    43384              
  Branches       4793     4793              
============================================
- Hits          16843    16842       -1     
  Misses        24679    24679              
- Partials       1862     1863       +1

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@zhuangchong zhuangchong modified the milestones: 3.1.8, 3.1.9 Aug 15, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

zhuangchong
zhuangchong approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhuangchong zhuangchong merged commit 9083f9d into apache:dev Sep 19, 2023
@zhuangchong
Copy link
Contributor

zhuangchong commented Sep 19, 2023

@Yhr-N
Thank you for your valuable contribution. Your PR is excellent! I would like to establish a deeper communication with you. You can reach me via email or add me on WeChat (KerwinZhuang). When contacting me, please provide your identity for reference. If you encounter any difficulties with DolphinScheduler, I am more than happy to assist you and help you become familiar with the platform.

zhuangchong pushed a commit that referenced this pull request Sep 19, 2023
@Yhr-N @zhuangchong
[Fix-14546] seatunnel unable submit spark job to spark (#14617)
df9aa41
zhongjiajie pushed a commit that referenced this pull request Oct 11, 2023
@Yhr-N @zhongjiajie
[Fix-14546] seatunnel unable submit spark job to spark (#14617)
87d6092 
(cherry picked from commit 9083f9d)
@zhuangchong zhuangchong added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SbloodyS SbloodyS SbloodyS left review comments

@zhuangchong zhuangchong zhuangchong approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

Assignees

@Yhr-N Yhr-N

Labels

3.1.x for 3.1.x version backend bug Something isn't working first time contributor First-time contributor ready-to-merge release cherry-pick Mark this issue/PR had cherry-pick for release version

Projects

None yet

Milestone

3.1.9

Development

Successfully merging this pull request may close these issues.

[Bug] [Task Plugin] seatunnel unable submit spark job to spark://

6 participants

@Yhr-N @CallMeKingsley97 @fuchanghai @SbloodyS @codecov-commenter @zhuangchong