[Feature-14545][Master][UI]Cross workflow parameter passing #14552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orange-Summer
requested review from
Amy0104,
SbloodyS,
caishunfeng,
ruanwenjun and
songjianet
as code owners
Orange-Summer
changed the title
Orange-Summer
changed the title
EricGao888
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #14552 +/- ##
============================================
- Coverage 38.48% 38.44% -0.04%
+ Complexity 4549 4547 -2
============================================
Files 1254 1254
Lines 43709 43743 +34
Branches 4822 4826 +4
============================================
- Hits 16822 16819 -3
- Misses 25013 25050 +37
Partials 1874 1874
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
# Conflicts: # dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
songjianet
previously approved these changes
Jul 18, 2023
SbloodyS
added
3.2.0
SbloodyS
requested changes
Jul 18, 2023
...rc/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThreadPool.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThreadPool.java
Outdated
Show resolved
Hide resolved
Co-authored-by: xiangzihao <[email protected]>
Co-authored-by: xiangzihao <[email protected]>
SbloodyS
requested changes
Jul 18, 2023
...rc/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThreadPool.java
Outdated
Show resolved
Hide resolved
SbloodyS
approved these changes
Jul 19, 2023
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
zhongjiajie
added a commit
that referenced
this pull request
Jul 20, 2023
* feat: cross-workflow parameter passing * refactor: remove useless parameters * refactor: remove useless code * refactor: code format * docs: update docs * docs: docs format * more effective information Co-authored-by: xiangzihao <[email protected]> * more effective information Co-authored-by: xiangzihao <[email protected]> * fix: wrong writing of log code * fix: perfect error log --------- Co-authored-by: xiangzihao <[email protected]> Co-authored-by: xiangzihao <[email protected]> Co-authored-by: Rick Cheng <[email protected]> Co-authored-by: Jay Chung <[email protected]> (cherry picked from commit af2986e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
cross-workflow parameter passing
close #14545
Brief change log
add relevant code in module dolphinscheduler-ui
add code in
submitPostNodemethod ofWorkflowExecuteRunnable.javaadd method
crossWorkflowParameterPassinginWorkflowExecuteThreadPool.javaDesign and usage documentation can be seen here #14545
Verify this pull request
This change can be verified as follows:
Manually verified the change by testing locally.