[Feature-14542][K8S] add prometheus serviceMonitor #14539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gallardot <[email protected]>
Codecov Report
@@ Coverage Diff @@
## dev #14539 +/- ##
=========================================
Coverage 38.68% 38.68%
- Complexity 4576 4578 +2
=========================================
Files 1241 1241
Lines 43568 43568
Branches 4828 4826 -2
=========================================
+ Hits 16853 16856 +3
+ Misses 24847 24844 -3
Partials 1868 1868 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Gallardot
changed the title
Member
|
Hi @EricGao888, would you like to take a look? |
EricGao888
approved these changes
Jul 17, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
zhongjiajie
pushed a commit
that referenced
this pull request
Jul 20, 2023
Signed-off-by: Gallardot <[email protected]> Co-authored-by: Eric Gao <[email protected]> (cherry picked from commit f5be784)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Adding prometheus serviceMonitor will help improve the overall project observability
close #14542
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
enable serviceMonitor with values
prometheus's target page will see the following effect
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md