[fix-#14447]The judgment in k8sUtils#getPodLog is not accurate #14448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuchanghai
requested review from
SbloodyS,
caishunfeng and
zhuangchong
as code owners
Codecov Report
@@ Coverage Diff @@
## dev #14448 +/- ##
============================================
- Coverage 38.52% 38.52% -0.01%
+ Complexity 4555 4554 -1
============================================
Files 1236 1236
Lines 43486 43486
Branches 4817 4817
============================================
- Hits 16755 16751 -4
- Misses 24875 24878 +3
- Partials 1856 1857 +1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
Radeity
reviewed
Jul 4, 2023
...duler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/K8sUtils.java
Show resolved
Hide resolved
Member
|
PTAL @Radeity |
Radeity
approved these changes
Jul 7, 2023
zhuangchong
pushed a commit
that referenced
this pull request
Jul 10, 2023
IT-Kwj
pushed a commit
to IT-Kwj/dolphinscheduler
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
plz close : #14447
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.