Skip to content

Conversation

@ligenhw
Copy link
Contributor

@ligenhw ligenhw commented Jul 4, 2023

fix #14441

alert-plugin-instances api, if no alert-plugin-instances, it will response an empty list, but not null

    alert-plugin-instances api, if no alert-plugin-instances, it will response an empty list, but not null
@SbloodyS SbloodyS added bug Something isn't working 3.1.x for 3.1.x version labels Jul 4, 2023
@SbloodyS SbloodyS added this to the 3.1.8 milestone Jul 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #14444 (dbe6e4d) into dev (dec066f) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

❗ Current head dbe6e4d differs from pull request most recent head e3d50eb. Consider uploading reports for the commit e3d50eb to get more accurate results

@@             Coverage Diff              @@
##                dev   #14444      +/-   ##
============================================
- Coverage     38.55%   38.52%   -0.03%     
+ Complexity     4556     4553       -3     
============================================
  Files          1236     1236              
  Lines         43457    43457              
  Branches       4814     4815       +1     
============================================
- Hits          16754    16742      -12     
- Misses        24846    24861      +15     
+ Partials       1857     1854       -3     
Impacted Files Coverage Δ
...i/service/impl/AlertPluginInstanceServiceImpl.java 63.86% <33.33%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@SbloodyS SbloodyS merged commit d8cf0f8 into apache:dev Jul 4, 2023
IT-Kwj pushed a commit to IT-Kwj/dolphinscheduler that referenced this pull request Jul 14, 2023
alert-plugin-instances api, if no alert-plugin-instances, it will response an empty list, but not null

Co-authored-by: ligen60 <[email protected]>
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
alert-plugin-instances api, if no alert-plugin-instances, it will response an empty list, but not null

Co-authored-by: ligen60 <[email protected]>
(cherry picked from commit d8cf0f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.1.x for 3.1.x version backend bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Alarm Instance Manage] Search result list error

4 participants