Skip to content

[Feature-14404][datasource-plugin] add HANA datasource #14404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhongjiajie merged 14 commits into from
Jun 28, 2023
Merged

[Feature-14404][datasource-plugin] add HANA datasource #14404

zhongjiajie merged 14 commits into from
Jun 28, 2023

Conversation

@IT-Kwj
Copy link
Contributor

@IT-Kwj IT-Kwj commented Jun 26, 2023 •
edited
Loading

[Feature-14404][datasource-plugin] add HANA datasource

@github-actions github-actions bot added backend UI ui and front end related labels Jun 26, 2023
@IT-Kwj IT-Kwj closed this Jun 26, 2023
@IT-Kwj IT-Kwj reopened this Jun 26, 2023
@IT-Kwj IT-Kwj closed this Jun 26, 2023
@IT-Kwj IT-Kwj reopened this Jun 26, 2023
@SbloodyS SbloodyS changed the title Dev hana [Feature-14404][datasource-plugin] add HANA datasource Jun 26, 2023
@SbloodyS SbloodyS requested a review from zhongjiajie June 26, 2023 15:02
@SbloodyS SbloodyS added feature new feature first time contributor First-time contributor 3.2.0 for 3.2.0 version labels Jun 26, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone Jun 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023 •
edited
Loading

Codecov Report

Merging #14404 (3004359) into dev (091d869) will increase coverage by 0.00%.
The diff coverage is 30.76%.

❗ Current head 3004359 differs from pull request most recent head 54d229c. Consider uploading reports for the commit 54d229c to get more accurate results

@@            Coverage Diff            @@
##                dev   #14404   +/-   ##
=========================================
  Coverage     38.50%   38.51%           
+ Complexity     4560     4550   -10     
=========================================
  Files          1237     1237           
  Lines         43537    43508   -29     
  Branches       4815     4813    -2     
=========================================
- Hits          16764    16757    -7     
+ Misses        24918    24894   -24     
- Partials       1855     1857    +2
Impacted Files Coverage Δ
...cheduler/common/constants/DataSourceConstants.java 0.00% <ø> (ø)
...apache/dolphinscheduler/dao/entity/DataSource.java 18.18% <ø> (ø)
...asource/api/datasource/BaseDataSourceParamDTO.java 40.42% <ø> (+4.57%) ⬆️
...nscheduler/service/process/ProcessServiceImpl.java 30.74% <ø> (-0.24%) ⬇️
.../org/apache/dolphinscheduler/spi/enums/DbType.java 0.00% <0.00%> (ø)
...api/service/impl/ProcessDefinitionServiceImpl.java 35.48% <20.00%> (+0.04%) ⬆️
...er/api/service/impl/TaskDefinitionServiceImpl.java 46.01% <33.33%> (+1.96%) ⬆️
...eduler/api/service/impl/DataSourceServiceImpl.java 48.46% <50.00%> (-0.95%) ⬇️
...scheduler/api/controller/DataSourceController.java 38.70% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

zhongjiajie
zhongjiajie reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but can you add some docs of this new datasource? we have example docs in 18d176c#diff-2f456cf13c39c7e0d2289222ec6cb6e84a0f234d0a25970358fea96d6d6674b3

all you have to do is modify docdev.js and add two HANA.md files for both Chinese and English version

@zhongjiajie zhongjiajie added the miss:docs missing documents in PR label Jun 27, 2023
@zhongjiajie
Copy link
Member

zhongjiajie commented Jun 27, 2023

approval the ci run

@zhongjiajie
Copy link
Member

zhongjiajie commented Jun 27, 2023

need to run mvn spotless:apply to format your docs @IT-Kwj

@zhongjiajie zhongjiajie added ready-to-merge and removed miss:docs missing documents in PR labels Jun 28, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 28, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@zhongjiajie
Copy link
Member

zhongjiajie commented Jun 28, 2023

the deadline of docs will be fix in #14406

@zhongjiajie zhongjiajie merged commit 7a24be0 into apache:dev Jun 28, 2023
@zhongjiajie
Copy link
Member

zhongjiajie commented Jun 28, 2023

Hi @IT-Kwj , what a good addition to dolphinscheduler, it help sap Hana user user dolphinscheudler easier, and welcome to join the contributors community 🎉 .
If you want to continue your contribution but could not find issues, maybe you could start in https://github.com/apache/dolphinscheduler/contribute
or just search our issue list https://github.com/apache/dolphinscheduler/issues, Looking for something you interesting.

@zhongjiajie zhongjiajie mentioned this pull request Jun 28, 2023
Merged
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
@IT-Kwj @zhongjiajie
[Feature-14404][datasource-plugin] add HANA datasource (#14404)
b0a7e15 
---------

Co-authored-by: WeiJian Kong <>
Co-authored-by: xujiaqiang <Xjq634828243>
(cherry picked from commit 7a24be0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104

Assignees

@IT-Kwj IT-Kwj

Labels

3.2.0 for 3.2.0 version backend document feature new feature first time contributor First-time contributor ready-to-merge UI ui and front end related

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@IT-Kwj @codecov-commenter @zhongjiajie @SbloodyS