Skip to content

[Improvement-14318][UI] migrate version 2.x workflow definition d3 tree view to version 3.x #14382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
songjianet merged 5 commits into from
Jul 4, 2023
Merged

[Improvement-14318][UI] migrate version 2.x workflow definition d3 tree view to version 3.x #14382

songjianet merged 5 commits into from
Jul 4, 2023

Conversation

@yeahhhz
Copy link
Contributor

@yeahhhz yeahhhz commented Jun 20, 2023

Purpose of the pull request

close #14318

Brief change log

  • migrate version 2.x d3 tree view and replace version 3.x.

Verify this pull request

截屏2023-06-20 15 12 44

@yeahhhz yeahhhz requested a review from songjianet as a code owner June 20, 2023 07:32
@github-actions github-actions bot added the UI ui and front end related label Jun 20, 2023
@yeahhhz yeahhhz changed the title [Improvement][UI] migrate version 2.x workflow definition d3 tree view to version 3.x [Improvement-14318][UI] migrate version 2.x workflow definition d3 tree view to version 3.x Jun 20, 2023
@SbloodyS SbloodyS added feature new feature 3.2.0 for 3.2.0 version labels Jun 21, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone Jun 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023 •
edited
Loading

Codecov Report

Merging #14382 (81d77a2) into dev (f840b17) will increase coverage by 0.04%.
The diff coverage is 40.00%.

❗ Current head 81d77a2 differs from pull request most recent head 0f0c129. Consider uploading reports for the commit 0f0c129 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14382      +/-   ##
============================================
+ Coverage     38.52%   38.56%   +0.04%     
+ Complexity     4564     4561       -3     
============================================
  Files          1237     1236       -1     
  Lines         43538    43456      -82     
  Branches       4814     4812       -2     
============================================
- Hits          16771    16758      -13     
+ Misses        24911    24841      -70     
- Partials       1856     1857       +1
Impacted Files Coverage Δ
...scheduler/api/dto/resources/ResourceComponent.java 26.66% <ø> (+1.66%) ⬆️
...api/dto/resources/visitor/ResourceTreeVisitor.java 72.09% <ø> (-0.64%) ⬇️
...nscheduler/api/security/impl/ldap/LdapService.java 5.76% <0.00%> (-0.62%) ⬇️
...heduler/api/service/impl/ResourcesServiceImpl.java 44.48% <ø> (+0.61%) ⬆️
...cheduler/common/constants/DataSourceConstants.java 0.00% <ø> (ø)
...heduler/common/log/remote/OssRemoteLogHandler.java 0.00% <0.00%> (ø)
...apache/dolphinscheduler/dao/entity/DataSource.java 18.18% <ø> (ø)
...asource/api/datasource/BaseDataSourceParamDTO.java 40.42% <ø> (+4.57%) ⬆️
...nscheduler/service/process/ProcessServiceImpl.java 30.74% <ø> (-0.24%) ⬇️
.../org/apache/dolphinscheduler/spi/enums/DbType.java 0.00% <0.00%> (ø)
... and 16 more

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhongjiajie zhongjiajie added the first time contributor First-time contributor label Jun 28, 2023
@zhongjiajie zhongjiajie requested a review from devosend June 28, 2023 06:30
@zhongjiajie
Copy link
Member

zhongjiajie commented Jun 28, 2023

do you have time to take a look at this pr @devosend

songjianet
songjianet previously approved these changes Jun 29, 2023
View reviewed changes
@songjianet
Copy link
Member

songjianet commented Jul 3, 2023

Please deal with the problem of front-end CI Build error. @yeahhhz

@yeahhhz yeahhhz requested a review from Amy0104 as a code owner July 3, 2023 05:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@songjianet songjianet merged commit 0880549 into apache:dev Jul 4, 2023
IT-Kwj pushed a commit to IT-Kwj/dolphinscheduler that referenced this pull request Jul 14, 2023
@yeahhhz
[Improvement-14318][UI] migrate version 2.x workflow definition d3 tr…
7efbfc4 
…ee view to version 3.x (apache#14382)

* [Improvement][UI] migrate version 2.x workflow definition d3 tree view to version 3.x

* remove unnessnary code

* fix code smells

* update lock file to fix front-end CI Build error

* update package.json
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
@yeahhhz @zhongjiajie
[Improvement-14318][UI] migrate version 2.x workflow definition d3 tr…
1be2dc1 
…ee view to version 3.x (#14382)

* [Improvement][UI] migrate version 2.x workflow definition d3 tree view to version 3.x

* remove unnessnary code

* fix code smells

* update lock file to fix front-end CI Build error

* update package.json

(cherry picked from commit 0880549)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SbloodyS SbloodyS SbloodyS left review comments

@songjianet songjianet songjianet approved these changes

@devosend devosend Awaiting requested review from devosend

@Amy0104 Amy0104 Awaiting requested review from Amy0104

Assignees

@yeahhhz yeahhhz

Labels

3.2.0 for 3.2.0 version feature new feature first time contributor First-time contributor UI ui and front end related

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

[Improvement][UI] migrate version 2.x workflow definition d3 tree view to version 3.x

5 participants

@yeahhhz @codecov-commenter @zhongjiajie @songjianet @SbloodyS