Skip to content

[Alert] [HTTP Plugin] Lose HTTP port #14341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhongjiajie merged 2 commits into from
Jun 14, 2023
Merged

[Alert] [HTTP Plugin] Lose HTTP port #14341

zhongjiajie merged 2 commits into from
Jun 14, 2023

Conversation

@qingwli
Copy link
Member

@qingwli qingwli commented Jun 13, 2023

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023 •
edited
Loading

Codecov Report

Merging #14341 (5586357) into dev (66e09dc) will decrease coverage by 0.19%.
The diff coverage is 20.36%.

❗ Current head 5586357 differs from pull request most recent head cc88e06. Consider uploading reports for the commit cc88e06 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14341      +/-   ##
============================================
- Coverage     38.65%   38.47%   -0.19%     
- Complexity     4534     4562      +28     
============================================
  Files          1236     1239       +3     
  Lines         43185    43582     +397     
  Branches       4779     4822      +43     
============================================
+ Hits          16695    16766      +71     
- Misses        24651    24955     +304     
- Partials       1839     1861      +22
Impacted Files Coverage Δ
...low/instance/pause/pause/PauseExecuteFunction.java 0.00% <0.00%> (ø)
...or/workflow/instance/stop/StopExecuteFunction.java 0.00% <0.00%> (ø)
...api/service/impl/TaskDefinitionLogServiceImpl.java 7.69% <0.00%> (ø)
...uler/api/service/impl/TaskInstanceServiceImpl.java 51.79% <0.00%> (ø)
...e/dolphinscheduler/common/constants/Constants.java 75.00% <ø> (ø)
...ler/server/master/event/TaskDelayEventHandler.java 0.00% <0.00%> (ø)
.../server/master/event/TaskDispatchEventHandler.java 0.00% <0.00%> (ø)
...er/server/master/event/TaskResultEventHandler.java 0.00% <0.00%> (ø)
...r/server/master/event/TaskRunningEventHandler.java 0.00% <0.00%> (ø)
...ler/server/master/event/TaskStateEventHandler.java 0.00% <0.00%> (ø)
... and 44 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@qingwli
Copy link
Member Author

qingwli commented Jun 14, 2023

PTAL @caishunfeng @SbloodyS @EricGao888

@zhongjiajie
Copy link
Member

zhongjiajie commented Jun 14, 2023

Could we also add a test case for it? @qingwli

@zhongjiajie
Copy link
Member

zhongjiajie commented Jun 14, 2023

approval to run test

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zhongjiajie zhongjiajie added the bug Something isn't working label Jun 14, 2023
@zhongjiajie zhongjiajie added this to the 3.1.8 milestone Jun 14, 2023
@zhongjiajie zhongjiajie added 3.1.x for 3.1.x version ready-to-merge labels Jun 14, 2023
@zhongjiajie zhongjiajie merged commit c1a6790 into apache:dev Jun 14, 2023
@qingwli qingwli deleted the fix-http-alert-bug branch June 14, 2023 09:45
zhuangchong pushed a commit that referenced this pull request Jun 26, 2023
@qingwli @zhuangchong
cherry-pick [Alert] [HTTP Plugin] Lose HTTP port
64e81c0 
#14341
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
@qingwli @zhongjiajie
[Alert] [HTTP Plugin] Lose HTTP port (#14341)
30171c4 
(cherry picked from commit c1a6790)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@kezhenxu94 kezhenxu94 Awaiting requested review from kezhenxu94

@caishunfeng caishunfeng Awaiting requested review from caishunfeng

Assignees

@qingwli qingwli

Labels

3.1.x for 3.1.x version backend bug Something isn't working ready-to-merge

Projects

None yet

Milestone

3.1.8

Development

Successfully merging this pull request may close these issues.

[Alert] [HTTP Plugin] Lose HTTP port

4 participants

@qingwli @codecov-commenter @zhongjiajie @zhuangchong