Skip to content

[improvement][task-plugin]Remove the HiveSQL connection pool and change to the original JDBC submission #14183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MonsterChenzhuo wants to merge 2 commits into from
Closed

[improvement][task-plugin]Remove the HiveSQL connection pool and change to the original JDBC submission #14183

MonsterChenzhuo wants to merge 2 commits into from

Conversation

@MonsterChenzhuo
Copy link
Contributor

@MonsterChenzhuo MonsterChenzhuo commented May 23, 2023 •
edited
Loading

Purpose of the pull request

close #14184

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@mergeable mergeable bot removed the backend label May 23, 2023
@MonsterChenzhuo MonsterChenzhuo changed the title [Improv][Task HiveSQL] Remove the connection pool submission method a… [Improv- 14184][Task HiveSQL]Remove the HiveSQL connection pool and change to the original JDBC submission May 23, 2023
@MonsterChenzhuo MonsterChenzhuo changed the title [Improv- 14184][Task HiveSQL]Remove the HiveSQL connection pool and change to the original JDBC submission [Improv- 14184][Task sql]Remove the HiveSQL connection pool and change to the original JDBC submission May 23, 2023
@MonsterChenzhuo MonsterChenzhuo changed the title [Improv- 14184][Task sql]Remove the HiveSQL connection pool and change to the original JDBC submission [Improv- 14184][task plugin][Task sql]Remove the HiveSQL connection pool and change to the original JDBC submission May 23, 2023
@MonsterChenzhuo MonsterChenzhuo changed the title [Improv- 14184][task plugin][Task sql]Remove the HiveSQL connection pool and change to the original JDBC submission [Improv- 14184][task plugin][task sql]Remove the HiveSQL connection pool and change to the original JDBC submission May 23, 2023
@MonsterChenzhuo MonsterChenzhuo changed the title [Improv- 14184][task plugin][task sql]Remove the HiveSQL connection pool and change to the original JDBC submission [Improv-14184][task plugin][task sql]Remove the HiveSQL connection pool and change to the original JDBC submission May 23, 2023
@MonsterChenzhuo
Copy link
Contributor Author

MonsterChenzhuo commented May 23, 2023

图片 图片 submit test

@MonsterChenzhuo MonsterChenzhuo changed the title [Improv-14184][task plugin][task sql]Remove the HiveSQL connection pool and change to the original JDBC submission [Improvement][task plugin][task sql]Remove the HiveSQL connection pool and change to the original JDBC submission May 23, 2023
@MonsterChenzhuo MonsterChenzhuo changed the title [Improvement][task plugin][task sql]Remove the HiveSQL connection pool and change to the original JDBC submission [improvement][task plugin][task sql]Remove the HiveSQL connection pool and change to the original JDBC submission May 23, 2023
@MonsterChenzhuo MonsterChenzhuo changed the title [improvement][task plugin][task sql]Remove the HiveSQL connection pool and change to the original JDBC submission [improvement][task]Remove the HiveSQL connection pool and change to the original JDBC submission May 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023 •
edited
Loading

Codecov Report

Merging #14183 (58d826d) into dev (5c4ba41) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 58d826d differs from pull request most recent head 766a05c. Consider uploading reports for the commit 766a05c to get more accurate results

@@             Coverage Diff              @@
##                dev   #14183      +/-   ##
============================================
- Coverage     38.25%   38.22%   -0.03%     
+ Complexity     4464     4463       -1     
============================================
  Files          1228     1228              
  Lines         42884    42904      +20     
  Branches       4762     4765       +3     
============================================
- Hits          16406    16402       -4     
- Misses        24671    24694      +23     
- Partials       1807     1808       +1
Impacted Files Coverage Δ
...e/dolphinscheduler/common/constants/Constants.java 75.00% <ø> (ø)
...ache/dolphinscheduler/plugin/task/sql/SqlTask.java 2.72% <0.00%> (-0.23%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MonsterChenzhuo MonsterChenzhuo changed the title [improvement][task]Remove the HiveSQL connection pool and change to the original JDBC submission [improvement][task]Remove the HiveSQL connection pool and change to the original JDBC submission v3.1.6 May 23, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@MonsterChenzhuo MonsterChenzhuo changed the title [improvement][task]Remove the HiveSQL connection pool and change to the original JDBC submission v3.1.6 [improvement][task]Remove the HiveSQL connection pool and change to the original JDBC submission May 23, 2023
@MonsterChenzhuo MonsterChenzhuo changed the title [improvement][task]Remove the HiveSQL connection pool and change to the original JDBC submission [improvement][task-plugin]Remove the HiveSQL connection pool and change to the original JDBC submission May 23, 2023
@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly 3.2.0 for 3.2.0 version labels May 24, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone May 24, 2023
@zhongjiajie
Copy link
Member

zhongjiajie commented May 24, 2023

ref: #14193

@MonsterChenzhuo MonsterChenzhuo mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

Assignees

@MonsterChenzhuo MonsterChenzhuo

Labels

3.2.0 for 3.2.0 version backend improvement make more easy to user or prompt friendly

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

[Improvement][Task sql]Remove the HiveSQL connection pool and change to the original JDBC submission

4 participants

@MonsterChenzhuo @codecov-commenter @zhongjiajie @SbloodyS