Skip to content

[Feature][UI] Support to view and manage all timing settings of a project. #14178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhuangchong merged 7 commits into from
May 24, 2023
Merged

[Feature][UI] Support to view and manage all timing settings of a project. #14178

zhuangchong merged 7 commits into from
May 24, 2023

Conversation

@calvinjiang
Copy link
Contributor

@calvinjiang calvinjiang commented May 22, 2023

Purpose of the pull request

This PR will close #14139 .

Brief change log

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.

The test result is as follows:

image

@github-actions github-actions bot added backend UI ui and front end related labels May 22, 2023
@calvinjiang calvinjiang added the 3.2.0 for 3.2.0 version label May 22, 2023
@calvinjiang calvinjiang added this to the 3.2.0 milestone May 22, 2023
@mergeable mergeable bot removed the 3.2.0 for 3.2.0 version label May 22, 2023
@mergeable mergeable bot added the 3.2.0 for 3.2.0 version label May 22, 2023
@calvinjiang calvinjiang added the feature new feature label May 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023 •
edited
Loading

Codecov Report

Merging #14178 (713b4cf) into dev (9979ea3) will decrease coverage by 0.05%.
The diff coverage is 10.71%.

❗ Current head 713b4cf differs from pull request most recent head d5a38b1. Consider uploading reports for the commit d5a38b1 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14178      +/-   ##
============================================
- Coverage     38.22%   38.18%   -0.05%     
+ Complexity     4461     4458       -3     
============================================
  Files          1227     1227              
  Lines         42793    42806      +13     
  Branches       4751     4757       +6     
============================================
- Hits          16358    16344      -14     
- Misses        24630    24655      +25     
- Partials       1805     1807       +2
Impacted Files Coverage Δ
...nscheduler/api/controller/SchedulerController.java 82.60% <ø> (ø)
...heduler/api/service/impl/SchedulerServiceImpl.java 30.13% <0.00%> (-0.09%) ⬇️
.../apache/dolphinscheduler/common/utils/OSUtils.java 29.55% <0.00%> (-0.38%) ⬇️
...heduler/plugin/storage/gcs/GcsStorageOperator.java 34.91% <0.00%> (-1.06%) ⬇️
...duler/plugin/storage/hdfs/HdfsStorageOperator.java 19.86% <0.00%> (ø)
...heduler/plugin/storage/oss/OssStorageOperator.java 35.17% <0.00%> (-0.83%) ⬇️
...scheduler/plugin/storage/s3/S3StorageOperator.java 33.71% <0.00%> (-0.78%) ⬇️
...server/worker/utils/TaskExecutionCheckerUtils.java 7.69% <ø> (ø)
...heduler/api/service/impl/ResourcesServiceImpl.java 43.70% <100.00%> (ø)
...che/dolphinscheduler/dao/utils/TaskCacheUtils.java 86.76% <100.00%> (ø)
... and 1 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@calvinjiang calvinjiang requested a review from zhuangchong May 22, 2023 11:09
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@zhuangchong zhuangchong merged commit 4c2e57c into apache:dev May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhuangchong zhuangchong zhuangchong approved these changes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

Assignees

No one assigned

Labels

3.2.0 for 3.2.0 version backend feature new feature UI ui and front end related

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

[Feature][UI] Add a new front-end page to manage all workflow timings.

3 participants

@calvinjiang @codecov-commenter @zhuangchong