Skip to content

[Feature][Task Plugin] Add Dynamic task to generate dynamic worklfows with list parameters #14127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jieguangzhou merged 13 commits into from
Jun 7, 2023
Merged

[Feature][Task Plugin] Add Dynamic task to generate dynamic worklfows with list parameters #14127

jieguangzhou merged 13 commits into from
Jun 7, 2023

Conversation

@jieguangzhou
Copy link
Member

@jieguangzhou jieguangzhou commented May 17, 2023 •
edited
Loading

Purpose of the pull request

close: #14125

DOC: https://github.com/jieguangzhou/dolphinscheduler/blob/feat/task-plugin-dynamic/docs/docs/en/guide/task/dynamic.md

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added backend UI ui and front end related labels May 17, 2023
@jieguangzhou jieguangzhou force-pushed the feat/task-plugin-dynamic branch from 535a663 to 784155c Compare May 23, 2023 10:27
@jieguangzhou jieguangzhou self-assigned this May 23, 2023
@jieguangzhou jieguangzhou added the 3.2.0 for 3.2.0 version label May 23, 2023
@jieguangzhou jieguangzhou added this to the 3.2.0 milestone May 23, 2023
@jieguangzhou jieguangzhou added the feature new feature label May 23, 2023
@mergeable mergeable bot removed the sql not sync label May 23, 2023
@apache apache deleted a comment from mergeable bot May 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023 •
edited
Loading

Codecov Report

Merging #14127 (6ce3fa0) into dev (4d798e7) will increase coverage by 0.01%.
The diff coverage is 39.47%.

❗ Current head 6ce3fa0 differs from pull request most recent head acd8337. Consider uploading reports for the commit acd8337 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14127      +/-   ##
============================================
+ Coverage     38.44%   38.46%   +0.01%     
- Complexity     4501     4527      +26     
============================================
  Files          1235     1241       +6     
  Lines         42989    43358     +369     
  Branches       4766     4797      +31     
============================================
+ Hits          16529    16678     +149     
- Misses        24632    24845     +213     
- Partials       1828     1835       +7
Impacted Files Coverage Δ
...uler/api/controller/ProcessInstanceController.java 65.30% <0.00%> (-4.26%) ⬇️
...r/api/service/impl/ProcessInstanceServiceImpl.java 55.49% <0.00%> (-4.96%) ⬇️
...cheduler/common/constants/CommandKeyConstants.java 0.00% <ø> (ø)
...che/dolphinscheduler/common/enums/CommandType.java 0.00% <0.00%> (ø)
...cheduler/common/enums/WorkflowExecutionStatus.java 0.00% <0.00%> (ø)
...er/common/utils/placeholder/BusinessTimeUtils.java 0.00% <ø> (ø)
...pache/dolphinscheduler/dao/entity/AccessToken.java 17.85% <0.00%> (ø)
...apache/dolphinscheduler/dao/entity/AlertGroup.java 4.00% <0.00%> (ø)
...apache/dolphinscheduler/dao/entity/DataSource.java 18.18% <0.00%> (ø)
...olphinscheduler/dao/entity/ProcessInstanceMap.java 0.00% <0.00%> (ø)
... and 21 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jieguangzhou jieguangzhou marked this pull request as ready for review May 23, 2023 11:35
@jieguangzhou
Copy link
Member Author

jieguangzhou commented May 23, 2023 •
edited
Loading

I will add UT later, please help to review the base codes

Radeity
Radeity reviewed May 27, 2023
View reviewed changes
@jieguangzhou jieguangzhou changed the title add task plugin dynamic [Feature][Task Plugin] Add Dynamic task to generate dynamic worklfows with list parameters Jun 5, 2023
zhongjiajie
zhongjiajie reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

@jieguangzhou jieguangzhou force-pushed the feat/task-plugin-dynamic branch 2 times, most recently from 26769ab to 17c8da1 Compare June 6, 2023 02:36
@jieguangzhou jieguangzhou force-pushed the feat/task-plugin-dynamic branch 3 times, most recently from fe597d6 to ddbf0be Compare June 6, 2023 23:35
caishunfeng
caishunfeng previously approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

41.1% 41.1% Coverage
0.0% 0.0% Duplication

devosend
devosend approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jieguangzhou jieguangzhou merged commit e7cdc7c into apache:dev Jun 7, 2023
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
@jieguangzhou @zhongjiajie
[Feature][Task Plugin] Add Dynamic task to generate dynamic worklfows…
1168fab 
… with list parameters (#14127)

* add dynamic task plugin

* fix ui

* update code

* add DOC

* ADD UT

* fix doc

* fix sanity check

* add upgrade ddl
* fix sql

(cherry picked from commit e7cdc7c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhongjiajie zhongjiajie zhongjiajie left review comments

@Radeity Radeity Radeity left review comments

@devosend devosend devosend approved these changes

@caishunfeng caishunfeng caishunfeng left review comments

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

Assignees

@jieguangzhou jieguangzhou

Labels

3.2.0 for 3.2.0 version backend document feature new feature UI ui and front end related

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

[Feature][Task Plugin] Add Dynamic task to generate dynamic worklfows with list parameters

6 participants

@jieguangzhou @codecov-commenter @devosend @caishunfeng @zhongjiajie @Radeity