Skip to content

Conversation

@AliceXiaoLu
Copy link
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@AliceXiaoLu
Copy link
Contributor Author

@caishunfeng Exception when using host in ipv6 format. For example,2001:1:0:4F3A::206:AE14 is valid IPV6, but !IPV4_PATTERN.matcher("2001:1:0:4F3A::206:AE14").matches() return true。

@AliceXiaoLu
Copy link
Contributor Author

  •    if (!IPV4_PATTERN.matcher(host).matches() || !IPV6_PATTERN.matcher(host).matches()) {
    
  •    //check is ipv4 or ipv6; if not, maybe hostname
    
  •    if (com.google.common.net.InetAddresses.isInetAddress(host)){
    
  •    }
    
  •    else if (!IPV4_PATTERN.matcher(host).matches() || !IPV6_PATTERN.matcher(host).matches()) {
           throw new IllegalArgumentException("datasource host illegal");
       }
    

@rickchengx
Copy link
Contributor

@caishunfeng Exception when using host in ipv6 format. For example,2001:1:0:4F3A::206:AE14 is valid IPV6, but !IPV4_PATTERN.matcher("2001:1:0:4F3A::206:AE14").matches() return true。

Could u please add this test case in AbstractDataSourceProcessorTest?

@SbloodyS SbloodyS added bug Something isn't working 3.1.6 labels May 4, 2023
@SbloodyS SbloodyS added this to the 3.1.6 milestone May 4, 2023
@ruanwenjun
Copy link
Member

UT failed.

@AliceXiaoLu
Copy link
Contributor Author

@ruanwenjun fix

@AliceXiaoLu
Copy link
Contributor Author

@ruanwenjun Please run UT again, Thank you.

@AliceXiaoLu
Copy link
Contributor Author

@caishunfeng Please help to review again

@EricGao888
Copy link
Member

@caishunfeng Please help to review again

I've rerun the CI.

@zhuangchong zhuangchong modified the milestones: 3.1.9, 3.1.10 Dec 26, 2023
@AliceXiaoLu
Copy link
Contributor Author

@caishunfeng 问题已处理,同时处理数据源获取时明文安全问题。

@AliceXiaoLu
Copy link
Contributor Author

@AliceXiaoLu
Copy link
Contributor Author

@zhuangchong @rickchengx @ruanwenjun Please help to review it again.

@SbloodyS SbloodyS added the 3.2.1 label Jan 12, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@SbloodyS SbloodyS merged commit cb5317f into apache:dev Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.1.x for 3.1.x version 3.2.1 backend bug Something isn't working ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants