-
Notifications
You must be signed in to change notification settings - Fork 5k
[bug] Exception when using host in ipv6 format #14040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ample:currentSchema=DB2INST1;characterEncoding=UTF-8;".should be ":"
…st).matches()"; I think we should use isInetAddress to check the host is isValid
|
@caishunfeng Exception when using host in ipv6 format. For example,2001:1:0:4F3A::206:AE14 is valid IPV6, but !IPV4_PATTERN.matcher("2001:1:0:4F3A::206:AE14").matches() return true。 |
|
Could u please add this test case in |
...rg/apache/dolphinscheduler/plugin/datasource/api/datasource/AbstractDataSourceProcessor.java
Show resolved
Hide resolved
|
UT failed. |
last week other modified this
|
@ruanwenjun fix |
|
@ruanwenjun Please run UT again, Thank you. |
|
@caishunfeng Please help to review again |
I've rerun the CI. |
|
@caishunfeng 问题已处理,同时处理数据源获取时明文安全问题。 |
|
@zhuangchong @rickchengx @ruanwenjun Please help to review it again. |
SbloodyS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|



Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md