[Fix-14008][registry] cache keep alive lease #14034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eye-gu
requested review from
caishunfeng,
kezhenxu94 and
ruanwenjun
as code owners
SbloodyS
reviewed
Apr 28, 2023
...rc/main/java/org/apache/dolphinscheduler/plugin/registry/etcd/EtcdKeepAliveLeaseManager.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #14034 +/- ##
============================================
+ Coverage 38.62% 38.65% +0.02%
- Complexity 4613 4619 +6
============================================
Files 1283 1284 +1
Lines 43855 43877 +22
Branches 4846 4846
============================================
+ Hits 16940 16961 +21
+ Misses 25038 25037 -1
- Partials 1877 1879 +2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
Member
|
PTAL @ruanwenjun |
eye-gu
force-pushed
the
Fix-14008
branch
3 times, most recently
from
4750b7a to
f5a8413
Compare
ruanwenjun
approved these changes
Jul 26, 2023
Member
ruanwenjun
left a comment
ruanwenjun
left a comment
There was a problem hiding this comment.
LGTM.
Since each put operation will create a new leaseId, and we will schedule heartbeat task to execute put to write heartbeat info, so this will cause memory leak.
This PR will hold the mapping of key to leaseId.
|
Kudos, SonarCloud Quality Gate passed! |
zhuangchong
pushed a commit
to zhuangchong/incubator-dolphinscheduler
that referenced
this pull request
Jul 31, 2023
zhuangchong
added a commit
that referenced
this pull request
Jul 31, 2023
…14666) Co-authored-by: eye-gu <[email protected]>
zhongjiajie
pushed a commit
that referenced
this pull request
Aug 30, 2023
(cherry picked from commit d87a0d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix #14008
Brief change log
add
EtcdKeepAliveLeaseManagerVerify this pull request
This pull request is code cleanup without any test coverage.