Skip to content

Conversation

@Radeity
Copy link
Member

@Radeity Radeity commented Apr 25, 2023

Purpose of the pull request

Brief change log

  • Set initial master heartbeat.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Radeity
Copy link
Member Author

Radeity commented Apr 25, 2023

cc @zhongjiajie @ruanwenjun

@zhongjiajie zhongjiajie added 3.0.x bug Something isn't working labels Apr 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (3.0.6-prepare@565bc97). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 72d1d26 differs from pull request most recent head a8b5813. Consider uploading reports for the commit a8b5813 to get more accurate results

@@               Coverage Diff                @@
##             3.0.6-prepare   #14014   +/-   ##
================================================
  Coverage                 ?   40.33%           
  Complexity               ?     4644           
================================================
  Files                    ?      889           
  Lines                    ?    35262           
  Branches                 ?     3905           
================================================
  Hits                     ?    14223           
  Misses                   ?    19649           
  Partials                 ?     1390           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if pass CI

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhongjiajie zhongjiajie merged commit 57fff8c into apache:3.0.6-prepare May 25, 2023
@zhongjiajie zhongjiajie added this to the 3.0.6 milestone May 25, 2023
@zhongjiajie
Copy link
Member

LGTM if pass CI

some of 3.0.x-prepare ci is alway failed, like python and docs, we could just ignore it

@zhongjiajie
Copy link
Member

Thanks @Radeity for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants