Support alert server HA #13865
Merged
Support alert server HA #13865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
SbloodyS,
caishunfeng and
kezhenxu94
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_alertServerSupportCluster
branch
5 times, most recently
from
41c2ab6 to
dfbecc8
Compare
Codecov Report
@@ Coverage Diff @@
## dev #13865 +/- ##
============================================
- Coverage 39.10% 38.93% -0.17%
+ Complexity 4460 4450 -10
============================================
Files 1155 1157 +2
Lines 42270 42340 +70
Branches 4760 4771 +11
============================================
- Hits 16528 16486 -42
- Misses 23929 24036 +107
- Partials 1813 1818 +5
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ruanwenjun
force-pushed
the
dev_wenjun_alertServerSupportCluster
branch
from
dfbecc8 to
483af6d
Compare
ruanwenjun
force-pushed
the
dev_wenjun_alertServerSupportCluster
branch
from
483af6d to
3f538d1
Compare
kezhenxu94
reviewed
Apr 4, 2023
...r/src/main/java/org/apache/dolphinscheduler/server/worker/registry/WorkerRegistryClient.java
Outdated
Show resolved
Hide resolved
...istry-api/src/main/java/org/apache/dolphinscheduler/registry/api/enums/RegistryNodeType.java
Outdated
Show resolved
Hide resolved
Comment on lines
-174
to
-175
| alert-listen-host: localhost | ||
| alert-listen-port: 50052 |
Member
There was a problem hiding this comment.
Can you review these changed configurations in the Helm Chart and see whether we have these there, if so remove them as well?
Member
Author
There was a problem hiding this comment.
I find these exist in kubernetes and terraform, and remove these, please help to check again.
|
SonarCloud Quality Gate failed. |
ruanwenjun
force-pushed
the
dev_wenjun_alertServerSupportCluster
branch
from
89e97da to
9e50103
Compare
ruanwenjun
force-pushed
the
dev_wenjun_alertServerSupportCluster
branch
from
9e50103 to
dc4f362
Compare
|
SonarCloud Quality Gate failed. |
kezhenxu94
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Right now, we can only support start single alert server, and need to write the alert server ip in worker's application.yml.
This will have some problems:
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md