Use bootstrap user as the default tenant #13825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
SbloodyS,
caishunfeng,
zhongjiajie and
zhuangchong
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_useBootstraptUserToExecuteTask
branch
2 times, most recently
from
87a38af to
3047546
Compare
Member
|
|
Member
|
we should also remove the section "Create Tenant" in https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/guide/start/quick-start.md section "Create Tenant", to make green hand path shorter |
ruanwenjun
changed the title
ruanwenjun
force-pushed
the
dev_wenjun_useBootstraptUserToExecuteTask
branch
from
3047546 to
88d9159
Compare
ruanwenjun
force-pushed
the
dev_wenjun_useBootstraptUserToExecuteTask
branch
3 times, most recently
from
98c0373 to
925dded
Compare
ruanwenjun
force-pushed
the
dev_wenjun_useBootstraptUserToExecuteTask
branch
from
925dded to
69802ae
Compare
Codecov Report
@@ Coverage Diff @@
## dev #13825 +/- ##
============================================
- Coverage 39.11% 39.08% -0.03%
+ Complexity 4437 4435 -2
============================================
Files 1140 1142 +2
Lines 42053 42007 -46
Branches 4753 4740 -13
============================================
- Hits 16448 16419 -29
+ Misses 23800 23788 -12
+ Partials 1805 1800 -5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
SonarCloud Quality Gate failed. |
Contributor
|
Good idea, LGTM👍 |
EricGao888
approved these changes
Mar 30, 2023
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
When workflow doesn't bind the tenant, use the worker bootstrap user as the tenant.
Brief change log
defaulttenant.Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md