[Feature-13429][Remote Logging] Add support for writing task logs to Google Cloud Storage #13777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickchengx
requested review from
EricGao888,
SbloodyS,
Tianqi-Dotes,
caishunfeng,
kezhenxu94,
ruanwenjun and
zhongjiajie
as code owners
Codecov Report
@@ Coverage Diff @@
## dev #13777 +/- ##
============================================
- Coverage 39.09% 39.03% -0.07%
- Complexity 4434 4438 +4
============================================
Files 1142 1143 +1
Lines 42007 42065 +58
Branches 4740 4739 -1
============================================
- Hits 16424 16421 -3
- Misses 23783 23847 +64
+ Partials 1800 1797 -3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Radeity
reviewed
Mar 22, 2023
...-common/src/main/java/org/apache/dolphinscheduler/common/log/remote/GcsRemoteLogHandler.java
Outdated
Show resolved
Hide resolved
...-common/src/main/java/org/apache/dolphinscheduler/common/log/remote/GcsRemoteLogHandler.java
Outdated
Show resolved
Hide resolved
rickchengx
force-pushed
the
Feature-13429
branch
from
edbcc17 to
33db3f8
Compare
Contributor
|
|
caishunfeng
reviewed
Mar 27, 2023
...-common/src/main/java/org/apache/dolphinscheduler/common/log/remote/GcsRemoteLogHandler.java
Show resolved
Hide resolved
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/LogUtils.java
Show resolved
Hide resolved
rickchengx
force-pushed
the
Feature-13429
branch
from
33db3f8 to
5c42f99
Compare
Contributor
Author
Hi, @caishunfeng , thanks a lot for your comment. I've update the pom |
rickchengx
force-pushed
the
Feature-13429
branch
from
5c42f99 to
3932e19
Compare
…Google Cloud Storage
rickchengx
force-pushed
the
Feature-13429
branch
from
3932e19 to
37fbae2
Compare
|
SonarCloud Quality Gate failed. |
rickchengx
removed request for
SbloodyS,
kezhenxu94,
ruanwenjun and
zhongjiajie
rickchengx
requested review from
caishunfeng
and removed request for
EricGao888 and
Tianqi-Dotes
Contributor
Author
|
Hi, @caishunfeng , could you please help review this again? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
Verify this pull request
manually test and UT