Skip to content

Roll back the logic of execution complement failure stop #13723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brave-lee merged 1 commit into from
Mar 13, 2023
Merged

Roll back the logic of execution complement failure stop #13723

brave-lee merged 1 commit into from
Mar 13, 2023

Conversation

@wcmolin
Copy link
Contributor

@wcmolin wcmolin commented Mar 11, 2023

rollback #12488

@wcmolin
Copy link
Contributor Author

wcmolin commented Mar 11, 2023

@JinyLeeChina please help me to review

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (2.0.9-prepare@33e345f). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head d7e4166 differs from pull request most recent head f96b242. Consider uploading reports for the commit f96b242 to get more accurate results

@@               Coverage Diff                @@
##             2.0.9-prepare   #13723   +/-   ##
================================================
  Coverage                 ?   20.61%           
  Complexity               ?     1600           
================================================
  Files                    ?      540           
  Lines                    ?    23110           
  Branches                 ?     2771           
================================================
  Hits                     ?     4764           
  Misses                   ?    17855           
  Partials                 ?      491

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 62 Bugs
Vulnerability E 13 Vulnerabilities
Security Hotspot E 12 Security Hotspots
Code Smell A 1090 Code Smells

16.9% 16.9% Coverage
5.4% 5.4% Duplication

@brave-lee brave-lee added this to the 2.0.9 milestone Mar 13, 2023
@brave-lee brave-lee self-requested a review March 13, 2023 08:48
brave-lee
brave-lee approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@brave-lee brave-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@brave-lee brave-lee merged commit e6f727b into apache:2.0.9-prepare Mar 13, 2023
@brave-lee brave-lee mentioned this pull request Mar 13, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brave-lee brave-lee brave-lee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.9

Development

Successfully merging this pull request may close these issues.

3 participants

@wcmolin @codecov-commenter @brave-lee